Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the WaitForPodsReady API with .recoveryTimeout field #4302

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

PBundyra
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Introduces a new waitForPodsReady.recoveryTimeout API, following this KEP

Which issue(s) this PR fixes:

Part of #2732

Special notes for your reviewer:

This is one of two PRs for this feature. This one introduces API only, and the second one adds logic.

Does this PR introduce a user-facing change?

Kueue exposes a new recovery mechanism as part of the WaitForPodsReady API. This evicts jobs which surpasses configured threshold for pod's recovery during runtime

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 18, 2025
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 18, 2025
Copy link

netlify bot commented Feb 18, 2025

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit af8b9e2
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/67b60e2521c5ef00085b5b5f

@PBundyra PBundyra changed the title Extend WaitForPodsReady API with RecoveryTimeout field Extend WaitForPodsReady API with .recoveryTimeout field Feb 18, 2025
@PBundyra PBundyra changed the title Extend WaitForPodsReady API with .recoveryTimeout field Extend the WaitForPodsReady API with .recoveryTimeout field Feb 18, 2025
@PBundyra PBundyra force-pushed the WaitForPodsReady-API branch 2 times, most recently from ebaa8be to c5187e0 Compare February 19, 2025 10:25
@mimowo
Copy link
Contributor

mimowo commented Feb 19, 2025

ack, will try to get here today

@PBundyra PBundyra force-pushed the WaitForPodsReady-API branch from c5187e0 to 2e466b5 Compare February 19, 2025 10:33
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall just wording tweaks

@mimowo
Copy link
Contributor

mimowo commented Feb 19, 2025

/lgtm
/approve
/hold
for additional pass from @tenzen-y .

This is just API, so in the worst case we rollback before 0.11, but seeing the implementation PR is already ready for review I think we can assume this is safe to be included in 0.11.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 19, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo, PBundyra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5b1ed96312ebd0ca7e444810ccf59c1304067a95

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2025
@k8s-ci-robot k8s-ci-robot requested a review from mimowo February 19, 2025 17:00
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants