Make Preemption.BorrowWithinCohort Incompatible with FairSharing #4298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gabesaba The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tenzen-y
reviewed
Feb 18, 2025
| var allErrs field.ErrorList | ||
| if preemption.ReclaimWithinCohort == kueue.PreemptionPolicyNever && | ||
| preemption.BorrowWithinCohort != nil && | ||
| preemption.BorrowWithinCohort.Policy != kueue.BorrowWithinCohortPolicyNever { | ||
| allErrs = append(allErrs, field.Invalid(path, preemption, "reclaimWithinCohort=Never and borrowWithinCohort.Policy!=Never")) | ||
| } | ||
| if w.fairSharingEnabled && preemption.BorrowWithinCohort != nil && preemption.BorrowWithinCohort.Policy != kueue.BorrowWithinCohortPolicyNever { | ||
| allErrs = append(allErrs, field.Invalid(path, preemption.BorrowWithinCohort, "FairSharing incompatible with borrowWithinCohort")) |
There was a problem hiding this comment.
Suggested change
| allErrs = append(allErrs, field.Invalid(path, preemption.BorrowWithinCohort, "FairSharing incompatible with borrowWithinCohort")) | |
| allErrs = append(allErrs, field.Invalid(path.Child("borrowWithinCohort").Child("policy"), preemption.BorrowWithinCohort.Policy, "FairSharing incompatible with borrowWithinCohort except for Never policy")) |
Actually, this incompatible came from policy, right?
|
I think this actually enhancement to improve UX. |
k8s-ci-robot
added
kind/feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
With #4165, these parameters together becomes a no-op.
Based on #4165 (comment), we decided to split out the logic and documentation change from the validation changes, as we may only cherry-pick the first set.
Which issue(s) this PR fixes:
Related to #3779
Special notes for your reviewer:
Does this PR introduce a user-facing change?