-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add configuration to kueue-viz backend #4178
base: main
Are you sure you want to change the base?
feat: add configuration to kueue-viz backend #4178
Conversation
Signed-off-by: lekaf974 <[email protected]>
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Welcome @lekaf974! |
Hi @lekaf974. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
Signed-off-by: lekaf974 <[email protected]>
/assign @akram |
/ok-to-test |
@kannon92 does it make sense to you ? using viper it allows to use files as well for configuration |
Yea this makes sense to me. |
Good let me know if you want some improvement or it is ok for now |
/lgtm |
LGTM label has been added. Git tree hash: 3f75c145ce12d95e9ba9574175bfa3ced0c07827
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lekaf974, mimowo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: lekaf974 [email protected]
What type of PR is this?
Propose a configuration based approach to be able to modify kueue-viz default behavior
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #3880
Special notes for your reviewer:
Does this PR introduce a user-facing change?