Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup legacy preemption logic #3602

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Cleanup legacy preemption logic #3602

wants to merge 1 commit into from
+46 −751

Conversation

gabesaba
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Cleanup MultiplePreemptions=false branch. Simplify code base.

Which issue(s) this PR fixes:

Fixes #3601

Special notes for your reviewer:

Does this PR introduce a user-facing change?

We deprecate legacy preemption logic, with MultiplePreemptions being the only behavior

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 20, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gabesaba
Once this PR has been reviewed and has the lgtm label, please assign tenzen-y for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify Netlify
Copy link

netlify bot commented Nov 20, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 70af31c
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/673df02976843e000852785c

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 20, 2024
gabesaba
gabesaba commented Nov 20, 2024
View reviewed changes
pkg/cache/clusterqueue_test.go
@@ -94,309 +94,6 @@ func TestClusterQueueUpdateWithFlavors(t *testing.T) {
}
}

func TestFitInCohort(t *testing.T) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can try to salvage these tests, if you think they're worth keeping. Let me know what you think, reviewers

@mimowo
Copy link
Contributor

mimowo commented Nov 20, 2024 •
edited
Loading

Thank you for the cleanup. It basically means MultiplePreemptions is graduated to stable, so we should reflect that in the kube_features. cc @tenzen-y ?

EDIT: what we typically do is we set the feature gate to stable, but keep it declared, so that users are not broken on upgrade if they have --feature-gate=MultiplePreemptions=true. Then we drop the declaration one or two releases later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PBundyra PBundyra Awaiting requested review from PBundyra

@tenzen-y tenzen-y Awaiting requested review from tenzen-y

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleanup legacy preemption logic (where MultiplePreemptions=false)
3 participants
@gabesaba @k8s-ci-robot @mimowo