Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wrapper for ProvisioningRequestConfig to util/testing package[WIP] #3560

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TusharMohapatra07
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Improve code quality

Which issue(s) this PR fixes:

Fixes #3472

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 16, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: TusharMohapatra07
Once this PR has been reviewed and has the lgtm label, please assign kerthcet for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 16, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @TusharMohapatra07. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 16, 2024
Copy link

netlify bot commented Nov 16, 2024

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit d0a8ce1
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6738c7092a06910008136e62
😎 Deploy Preview https://deploy-preview-3560--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@TusharMohapatra07
Copy link
Contributor Author

@PBundyra @mimowo What other operations(methods) are expected on the wrapper??

@mbobrovskyi
Copy link
Contributor

What is the purpose of this wrapper if it is never used?

@TusharMohapatra07
Copy link
Contributor Author

@mbobrovskyi The issue says to create a wrapper for ProvisioningRequestConfig.

@mbobrovskyi
Copy link
Contributor

@mbobrovskyi The issue says to create a wrapper for ProvisioningRequestConfig.

I agree the issue description is unclear. However, we need to not only create the wrapper but also use it in the code.

@PBundyra
Copy link
Contributor

@PBundyra @mimowo What other operations(methods) are expected on the wrapper??

We need methods to set:

  • .spec.provisioningClassName
  • .spec.parameters
  • .spec.managedResources
  • .spec.retryStrategy
  • .spec.retryStrategy.backoffLimitCount
  • .spec.retryStrategy.backoffBaseSeconds
  • .spec.retryStrategy.backoffMaxSeconds

And to create an actual object from a wrapper.

The point of introducing the wrapper would be indeed to use as @mbobrovskyi mentioned. Sorry for the unclear description. This change should be reflected in files:

  • pkg/controller/admissionchecks/provisioning/admissioncheck_reconciler_test.go
  • pkg/controller/admissionchecks/provisioning/controller_test.go
  • pkg/util/admissioncheck/admissioncheck_test.go
  • test/integration/controller/admissionchecks/provisioning/provisioning_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add wrapper for ProvisioningRequestConfig to util/testing package
4 participants