-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wrapper for ProvisioningRequestConfig
to util/testing package[WIP]
#3560
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: TusharMohapatra07 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @TusharMohapatra07. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
What is the purpose of this wrapper if it is never used? |
@mbobrovskyi The issue says to create a wrapper for |
I agree the issue description is unclear. However, we need to not only create the wrapper but also use it in the code. |
We need methods to set:
And to create an actual object from a wrapper. The point of introducing the wrapper would be indeed to use as @mbobrovskyi mentioned. Sorry for the unclear description. This change should be reflected in files:
|
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Improve code quality
Which issue(s) this PR fixes:
Fixes #3472