Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LeaderWorkerSet integration #3515

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

LeaderWorkerSet integration #3515

wants to merge 1 commit into from

Conversation

vladikkuzn
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds LeaderWorkerSet integration to job framework

Which issue(s) this PR fixes:

Fixes #3232

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Add integration for LeaderWorkerSet where Pods are managed by the pod-group integration.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Nov 12, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vladikkuzn
Once this PR has been reviewed and has the lgtm label, please assign tenzen-y for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 12, 2024
@vladikkuzn
Copy link
Contributor Author

/assign

@netlify Netlify
Copy link

netlify bot commented Nov 12, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 3036113
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/673ca0541dc1460008878543

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 12, 2024
@vladikkuzn
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Nov 12, 2024
@vladikkuzn vladikkuzn force-pushed the leaderworkerset-integration branch 2 times, most recently from 342d0de to 4519993 Compare November 12, 2024 13:48
@vladikkuzn
Copy link
Contributor Author

/test all

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 14, 2024
@k8s-ci-robot
Copy link
Contributor

@vladikkuzn: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kueue-verify-main 4519993 link true /test pull-kueue-verify-main
pull-kueue-test-e2e-main-1-29 4519993 link true /test pull-kueue-test-e2e-main-1-29
pull-kueue-test-e2e-main-1-28 4519993 link true /test pull-kueue-test-e2e-main-1-28
pull-kueue-test-e2e-main-1-31 4519993 link true /test pull-kueue-test-e2e-main-1-31
pull-kueue-test-e2e-main-1-30 4519993 link true /test pull-kueue-test-e2e-main-1-30
pull-kueue-test-tas-e2e-main 4519993 link true /test pull-kueue-test-tas-e2e-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@vladikkuzn vladikkuzn force-pushed the leaderworkerset-integration branch 3 times, most recently from ff26e24 to 6630f22 Compare November 19, 2024 14:25
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 19, 2024
vladikkuzn
vladikkuzn commented Nov 19, 2024
View reviewed changes
Makefile-test.mk
Comment on lines +121 to +122
run-test-tas-e2e-%: K8S_VERSION = $(@:run-test-tas-e2e-%=%)
run-test-tas-e2e-%: FORCE
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rollback

vladikkuzn
vladikkuzn commented Nov 19, 2024
View reviewed changes
pkg/controller/jobs/leaderworkerset/leaderworkerset_webhook.go
log := ctrl.LoggerFrom(ctx).WithName("leaderworkerset-webhook")
log.V(5).Info("Applying defaults")

// TODO: or get from annotation
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO

vladikkuzn
vladikkuzn commented Nov 19, 2024
View reviewed changes
pkg/controller/jobs/leaderworkerset/leaderworkerset_webhook.go
var _ webhook.CustomValidator = &Webhook{}

func (wh *Webhook) ValidateCreate(context.Context, runtime.Object) (warnings admission.Warnings, err error) {
// TODO: add validation of queue name
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO

vladikkuzn
vladikkuzn commented Nov 19, 2024
View reviewed changes
pkg/controller/jobs/leaderworkerset/leaderworkerset_webhook.go
workerTemplateGroupNameLabelPath,
)...)

// TODO(#...): support resizes later
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO create issue

vladikkuzn
vladikkuzn commented Nov 19, 2024
View reviewed changes
pkg/controller/jobs/leaderworkerset/leaderworkerset_webhook.go
sizePath,
)...)

// TODO(#...): support mutation of leader/worker templates later
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO create issue

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 21, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbobrovskyi mbobrovskyi mbobrovskyi left review comments

@denkensk denkensk Awaiting requested review from denkensk

@trasc trasc Awaiting requested review from trasc

Assignees

@vladikkuzn vladikkuzn

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MVP support for serving workloads running as LeaderWorkerSet
3 participants
@vladikkuzn @k8s-ci-robot @mbobrovskyi