Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KEP-2941]: Supporting Dynamic Resource Allocations in Kueue #3071

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kannon92
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

DRA support and Kueue

Which issue(s) this PR fixes:

KEP for #2941

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. labels Sep 16, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kannon92
Once this PR has been reviewed and has the lgtm label, please assign alculquicondor for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 16, 2024
Copy link

netlify bot commented Sep 16, 2024

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit a35c911
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/66edb9d0d02bd6000814220b

@kannon92 kannon92 changed the title Supporting Dynamic Resource Allocations in Kueue [KEP-2941]: Supporting Dynamic Resource Allocations in Kueue Sep 16, 2024
@kannon92
Copy link
Contributor Author

@kannon92
Copy link
Contributor Author

I brought this KEP up with wg-device-management. It seemed to over well and they pointed out a few improvements.

I added this KEP to the wg-batch agenda next week. Maybe from there we can continue to discuss this KEP.

@tenzen-y
Copy link
Member

I brought this KEP up with wg-device-management. It seemed to over well and they pointed out a few improvements.

I added this KEP to the wg-batch agenda next week. Maybe from there we can continue to discuss this KEP.

Yeah, I'm open to discussion. But, I will start to review this PR after the 0.9 release due to the 0.9 release tight deadline.

nominalQuota: 9
- name: "memory"
nominalQuota: "200Mi"
- name: "gpu.example.com"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgive the naive question, still getting familiar with DRA. How does this work exactly? Does the resulting workload end up with 2 GPUs from this claim? Do we need to differentiate between the "time-slice" vs "space-partition" GPUs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So claims correspond to device classes. We can only limit device classes so I think you would set up a device with time-slicing enabled. Your claim would request this device.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants