Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup legacy preemption logic (where MultiplePreemptions=false) #3601

Open
gabesaba opened this issue Nov 20, 2024 · 1 comment · May be fixed by #3602
Open

Cleanup legacy preemption logic (where MultiplePreemptions=false) #3601

gabesaba opened this issue Nov 20, 2024 · 1 comment · May be fixed by #3602
Assignees
@gabesaba
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@gabesaba
Copy link
Contributor

What would you like to be cleaned:
The branch where this does not hold.

kueue/pkg/scheduler/scheduler.go

Line 259 in 0b0b003

if features.Enabled(features.MultiplePreemptions) {

Why is this needed:
Simplify the code base. The new logic allows more accurate preemptions, and easier to understand
@gabesaba gabesaba added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Nov 20, 2024
@gabesaba
Copy link
Contributor Author

/assign

@gabesaba gabesaba linked a pull request Nov 20, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gabesaba gabesaba

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup legacy preemption logic gabesaba/kueue
1 participant
@gabesaba