-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fcos crio #11716
base: master
Are you sure you want to change the base?
Fix fcos crio #11716
Conversation
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: spaced The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @spaced. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
a9c92b3
to
1b5827c
Compare
I don't think we want to start supporting things other than upstream binaries directly.
Is fcbcf3c the source of the breakage ? If yes, I think the simpler thing would be to adjust path for coreos.
|
/ok-to-test |
What type of PR is this?
/kind bug
What this PR does / why we need it:
allow use fcos with cri-o (again)
Which issue(s) this PR fixes:
Fixes #11715
Special notes for your reviewer:
Does this PR introduce a user-facing change?: