-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]bump gateway_api_version to v1.2.0 #11636
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: KubeKyrie The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @KubeKyrie. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/remove-kind flake
/kind feature
@@ -1,4 +1,4 @@ | |||
--- | |||
gateway_api_enabled: false | |||
gateway_api_version: v1.1.0 | |||
gateway_api_version: v1.2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wrote this code at the beginning, only change this is useless, in order to support offline installation, I finally did not use to this variable (PR #11376), I hope that the version can be differentiated by folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for reminding.
- I do not understand how the support of offline installation affects this variable.
- And how should I do to upgrade gateway_api. Should v1.1.0 be retained after updating?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can refer #11376.
My imagination is that you could put the original Gateway API CRDs in the v1.1.0
folder, and you create a separate v1.2.0
folder for the new version, and then you could use the gateway_api_version
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, difference gateway-api version by folder is not very good for scaling. We can't add a directory for every version because the list will be very long after later versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because Gateway API release cycle is not very frequent, reserve 3 patch version I think it's appropriate.
If you have a better idea, you can suggest in a comment.
/ok-to-test |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Support Gateway API upgrade to v1.2.0
See https://gateway-api.sigs.k8s.io/guides/?h=crds#v12-upgrade-notes
Which issue(s) this PR fixes:
Fixes #11630
Special notes for your reviewer:
Does this PR introduce a user-facing change?: