-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update install ansible docs #11469
base: master
Are you sure you want to change the base?
Update install ansible docs #11469
Conversation
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi @jimyag. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jimyag The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
@@ -14,6 +14,7 @@ python3 -m venv $VENVDIR | |||
source $VENVDIR/bin/activate | |||
cd $KUBESPRAYDIR | |||
pip install -U -r requirements.txt | |||
pip install -U -r contrib/inventory_builder/requirements.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need this if you don't use the dynamic inventory, please make this clear
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did what
Lines 29 to 33 in 1798989
# Update Ansible inventory file with inventory builder | |
declare -a IPS=(10.10.1.3 10.10.1.4 10.10.1.5) | |
CONFIG_FILE=inventory/mycluster/hosts.yaml python3 contrib/inventory_builder/inventory.py ${IPS[@]} | |
# Review and change parameters under ``inventory/mycluster/group_vars`` |
Executing
CONFIG_FILE=inventory/z2air/hosts.yaml python contrib/inventory_builder/inventory.py ${IPS[@]}
gives the error Not a module named ruamel
.
Looking through the issue, I found a solution that requires the ruamel.yaml
module to be installed.
A number of people have had the same problem, and I think it's necessary to add the relevant description somewhere correct, but I'm not sure I'm adding it in the right place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then this line should be in the README just before using the inventory.py script, since it's not for installing ansible, but just to run the script.
/label ci-short |
@ant31: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #11465 #11418
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE