Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump openstack-cloud-controller-manager from 1.25.3 to 1.28.2 #11174

Merged
merged 1 commit into from
May 8, 2024
Merged

Bump openstack-cloud-controller-manager from 1.25.3 to 1.28.2 #11174

merged 1 commit into from
May 8, 2024

Conversation

tico88612
Copy link
Member

@tico88612 tico88612 commented May 7, 2024 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

OCCM registry change to registry.k8s.io and upgrade to Kubespray's current K8s version.

Which issue(s) this PR fixes:

Related #11107

Special notes for your reviewer:

latest tag is invalid in the OCCM image.

Does this PR introduce a user-facing change?:

- OpenStack Cloud Controller Manager upgrade to 1.28.2

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label May 7, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 7, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @tico88612. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 7, 2024
@tico88612 tico88612 mentioned this pull request May 7, 2024
Open
mzaian
mzaian approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@mzaian mzaian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 7, 2024
MrFreezeex
MrFreezeex reviewed May 7, 2024
View reviewed changes
Copy link
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! I have a small comment about the image repo change but otherwise, lgtm thanks!

...l_cloud_controller/openstack/templates/external-openstack-cloud-controller-manager-ds.yml.j2 Outdated Show resolved Hide resolved
@tico88612
Bump openstack-cloud-controller-manager from 1.25.3 to 1.28.2
830405a 
Registry change to registry.k8s.io

Signed-off-by: tico88612 <[email protected]>
@tico88612 tico88612 force-pushed the bump/openstack-cloud-provider branch from 26eeb50 to 830405a Compare May 8, 2024 00:51
@tico88612 tico88612 requested a review from MrFreezeex May 8, 2024 00:52
MrFreezeex
MrFreezeex approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@MrFreezeex MrFreezeex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrFreezeex, mzaian, tico88612

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5dc12b2 into kubernetes-sigs:master May 8, 2024
60 checks passed
@tico88612 tico88612 deleted the bump/openstack-cloud-provider branch May 8, 2024 12:55
pedro-peter pushed a commit to pedro-peter/kubespray that referenced this pull request May 8, 2024
@tico88612 @pedromcpedro
Bump openstack-cloud-controller-manager from 1.25.3 to 1.28.2 (kubern…
3c4f98b 
…etes-sigs#11174)

Registry change to registry.k8s.io

Signed-off-by: tico88612 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzaian mzaian mzaian approved these changes

@MrFreezeex MrFreezeex MrFreezeex approved these changes

@ErikJiang ErikJiang Awaiting requested review from ErikJiang

Assignees

@MrFreezeex MrFreezeex

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tico88612 @k8s-ci-robot @mzaian @MrFreezeex