📖 Fix: broken url in extending_cli_features_and_plugins.md #4341
Conversation
You can see the current 404 here: https://book.kubebuilder.io/plugins/extending/extending_cli_features_and_plugins#plugin-keys (after clicking on go the kubebuilder.io URL)
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: monteiro-renato The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @monteiro-renato. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/XS
| @@ -405,7 +405,7 @@ creating features or plugins that can rely on this information. | |||
| [kb-utils]: ./../../../../../pkg/plugin/util/util.go | |||
| [project-file-config]: ./../../reference/project-config.md | |||
| [cli]: ./../../../../../pkg/cli | |||
| [kb-go-plugin]: ./../../../../../pkg/plugins/golang/v4 | |||
| [kb-go-plugin]: https://github.com/kubernetes-sigs/kubebuilder/tree/book-v4/pkg/plugins/golang/v4 | |||
There was a problem hiding this comment.
We need to use the relative path on this one.
Could we not?
There was a problem hiding this comment.
Hmm, the sentence hints to the full code implementation (therefore I assume the initial intention was to link to a github URL).
I just noticed the same problem exists in the plugin's page in the book as well (i.e. try to click on the "base Golang plugin base.go.kubebuilder.io/v4" url).
There was a problem hiding this comment.
The Kustomize plugin docs also point to a Github url: https://github.com/kubernetes-sigs/kubebuilder/blob/master/docs/book/src/plugins/kustomize-v2.md?plain=1#L100
You can see the 404 here: https://book.kubebuilder.io/plugins/extending/extending_cli_features_and_plugins#plugin-keys
(after clicking on the go.kubebuilder.io URL)