✨ (go/v4): Add Hub and Spoke for conversion webhooks #4254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
the
do-not-merge/work-in-progress
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
camilamacedo86
force-pushed
the
huc-spoke
branch
2 times, most recently
from
7027ba2
to
0941851
Compare
k8s-ci-robot
added
size/XL
camilamacedo86
force-pushed
the
huc-spoke
branch
2 times, most recently
from
efe33fd
to
7216ea6
Compare
camilamacedo86
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
camilamacedo86
force-pushed
the
huc-spoke
branch
8 times, most recently
from
8b2b36d
to
233645d
Compare
camilamacedo86
changed the title
camilamacedo86
added a commit
to camilamacedo86/kubebuilder
that referenced
this pull request
Nov 2, 2024
The CA injection patch has **not** worked for `go/v4` and `kustomize/v2` (release `3.5.0`) due to the need to replace `vars` with `replacements`, as `vars` are no longer supported in the latest major versions of Kustomize. However, since webhook `--conversion` was an incomplete feature until the upcoming Kubebuilder future release `v4.4.0` (where [PR kubernetes-sigs#4254](kubernetes-sigs#4254) is expected to be merged), users likely didn’t encounter this issue or addressed it manually by fixing the scaffold. **Note:** This change only affects projects that require a **conversion webhook**.
camilamacedo86
force-pushed
the
huc-spoke
branch
from
54e55be
to
df915c0
Compare
camilamacedo86
added a commit
to camilamacedo86/kubebuilder
that referenced
this pull request
Nov 9, 2024
The CA injection patch has **not** worked for `go/v4` and `kustomize/v2` (release `3.5.0`) due to the need to replace `vars` with `replacements`, as `vars` are no longer supported in the latest major versions of Kustomize. However, since webhook `--conversion` was an incomplete feature until the upcoming Kubebuilder future release `v4.4.0` (where [PR kubernetes-sigs#4254](kubernetes-sigs#4254) is expected to be merged), users likely didn’t encounter this issue or addressed it manually by fixing the scaffold. **Note:** This change only affects projects that require a **conversion webhook**.
camilamacedo86
added a commit
to camilamacedo86/kubebuilder
that referenced
this pull request
Nov 9, 2024
The CA injection patch has **not** worked for `go/v4` and `kustomize/v2` (release `3.5.0`) due to the need to replace `vars` with `replacements`, as `vars` are no longer supported in the latest major versions of Kustomize. However, since webhook `--conversion` was an incomplete feature until the upcoming Kubebuilder future release `v4.4.0` (where [PR kubernetes-sigs#4254](kubernetes-sigs#4254) is expected to be merged), users likely didn’t encounter this issue or addressed it manually by fixing the scaffold. **Note:** This change only affects projects that require a **conversion webhook**.
camilamacedo86
added a commit
to camilamacedo86/kubebuilder
that referenced
this pull request
Nov 10, 2024
The CA injection patch has **not** worked for `go/v4` and `kustomize/v2` (release `3.5.0`) due to the need to replace `vars` with `replacements`, as `vars` are no longer supported in the latest major versions of Kustomize. However, since webhook `--conversion` was an incomplete feature until the upcoming Kubebuilder future release `v4.4.0` (where [PR kubernetes-sigs#4254](kubernetes-sigs#4254) is expected to be merged), users likely didn’t encounter this issue or addressed it manually by fixing the scaffold. **Note:** This change only affects projects that require a **conversion webhook**.
camilamacedo86
added a commit
to camilamacedo86/kubebuilder
that referenced
this pull request
Nov 10, 2024
The CA injection patch has **not** worked for `go/v4` and `kustomize/v2` (release `3.5.0`) due to the need to replace `vars` with `replacements`, as `vars` are no longer supported in the latest major versions of Kustomize. However, since webhook `--conversion` was an incomplete feature until the upcoming Kubebuilder future release `v4.4.0` (where [PR kubernetes-sigs#4254](kubernetes-sigs#4254) is expected to be merged), users likely didn’t encounter this issue or addressed it manually by fixing the scaffold. **Note:** This change only affects projects that require a **conversion webhook**.
camilamacedo86
force-pushed
the
huc-spoke
branch
2 times, most recently
from
b42ccaf
to
483d92d
Compare
k8s-ci-robot
added
size/XXL
camilamacedo86
force-pushed
the
huc-spoke
branch
9 times, most recently
from
501e28c
to
cc242e6
Compare
camilamacedo86
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
camilamacedo86
commented
Nov 10, 2024
| defaulting: true | ||
| spoke: | ||
| - v2 | ||
| - v2 |
There was a problem hiding this comment.
Would having many spokes make sense in this scenario? It might make more sense to convert V1 into another group(s), kind(s), like combining V1 and V2 or something similar.
I think we can have for now
- allow just one spoke version from A to B (Same Kind and Group)
- in the future, if we see what the users ask for, we can expand to support a list of GKV spokes.
- For advanced cases, users can move forward without informing the spoke. The conversion happens without the spoke. This allows users to use it still, but they must complete advanced steps manually.
Do you think this approach makes sense?
camilamacedo86
force-pushed
the
huc-spoke
branch
2 times, most recently
from
dd213e6
to
be62108
Compare
camilamacedo86
changed the title
camilamacedo86
force-pushed
the
huc-spoke
branch
from
be62108
to
e039767
Compare
This PR introduces the initial implementation of the hub-and-spoke model for handling conversion webhooks. The goal is to streamline the conversion process by utilizing a central hub to speak a specific version of the same Group and Kind. - **Single Spoke Support (A to B, Same Kind and Group):** The system will allow only one spoke version for conversions (i.e., converting from Version A to Version B within the same kind and group). - **Future Expansion (List of GKV Spokes):** In the future, based on user feedback or demand, we can expand to support a list of **GKV spokes**, allowing for greater flexibility in conversions across different versions, kinds, and groups. - **Advanced Case Handling (Manual Steps):** For more advanced cases, users can proceed without specifying a spoke. In this scenario, the conversion process will still occur without the spoke, enabling users to continue. However, they will be required to complete specific advanced steps manually. Closes; kubernetes-sigs#2589
camilamacedo86
force-pushed
the
huc-spoke
branch
from
e039767
to
9a11598
Compare
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the initial implementation of the hub-and-spoke model for handling conversion webhooks. The goal is to streamline the conversion process by utilizing a central hub to speak a specific version of the same Group and Kind.
How It Will Work:
Single Spoke Support (A to B, Same Kind and Group):
The system will allow only one spoke version for conversions (i.e., converting from Version A to Version B within the same kind and group).
Future Expansion (List of GKV Spokes):
In the future, based on user feedback or demand, we can expand to support a list of GKV spokes, allowing for greater flexibility in conversions across different versions, kinds, and groups.
Advanced Case Handling (Manual Steps):
For more advanced cases, users can proceed without specifying a spoke. In this scenario, the conversion process will still occur without the spoke, enabling users to continue. However, they will be required to complete specific advanced steps manually.
Closes; #2589