Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to debian bookworm as base image #3294

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Jul 4, 2023

Use the latest debian distribution for the haproxy and local-path-helper images.

Required by kubernetes/kubernetes#118996

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 4, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 4, 2023
images/haproxy/Dockerfile Outdated Show resolved Hide resolved
@aojea
Copy link
Contributor

aojea commented Jul 5, 2023

I have to build the images to publish them before merging, I bit swamped today,
/cc @BenTheElder

@BenTheElder
Copy link
Member

I have to build the images to publish them before merging, I bit swamped today,

we have automated builds on merge now, but you have to "promote" them to dockerhub for now (crane cp)

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 5, 2023
Use the latest debian distribution for the haproxy and local-path-helper
images.

Signed-off-by: Sascha Grunert <[email protected]>
@saschagrunert
Copy link
Member Author

saschagrunert commented Sep 5, 2023

Rebased the PR to update everything to bookworm. PTAL again @kubernetes-sigs/kind-maintainers

@aojea
Copy link
Contributor

aojea commented Sep 5, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2023
@k8s-ci-robot k8s-ci-robot merged commit a7c62c4 into kubernetes-sigs:main Sep 5, 2023
19 of 20 checks passed
@aojea
Copy link
Contributor

aojea commented Sep 5, 2023

hmm, 2 problems

 #21 3.513 
#21 3.515 E: Version '2.2.*' for 'haproxy' was not found
#21 ERROR: process "/bin/sh -c apt update &&     apt install -y --no-install-recommends haproxy=2.2.\\*       procps bash" did not complete successfully: exit code: 100

and

error: failed to solve: process "/bin/sh -c mkdir -p \"${STAGE_DIR}\" &&     stage-binary-and-deps.sh sh \"${STAGE_DIR}\" &&     stage-binary-and-deps.sh rm \"${STAGE_DIR}\" &&     stage-binary-and-deps.sh mkdir \"${STAGE_DIR}\" &&     find \"${STAGE_DIR}\"" did not complete successfully: exit code: 1
make: *** [/workspace/images/local-path-helper/../Makefile.common.in:39: build] Error 1

https://prow.k8s.io/?repo=kubernetes-sigs%2Fkind&type=postsubmit

@saschagrunert
Copy link
Member Author

@aojea #3350

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants