Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose peer certificates in round tripper response #3110

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

snehachhabria
Copy link
Contributor

What type of PR is this?
Add one of the following kinds:

/kind test
/area conformance

What this PR does / why we need it:
This PR exposes the peer certificates from the http response in round tripper.

Which issue(s) this PR fixes:
Fixes ##3020

Does this PR introduce a user-facing change?:


NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/test area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 22, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 22, 2024
Copy link
Member

@sunjayBhatia sunjayBhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks sufficient to capture the certs a backend may be presenting, i'm curious how this will be used in practice since there aren't any tests making assertions on this? I might be missing some context that needs to be added to the original issue, but if a backend is presenting an unexpected cert for example, we would likely get a TLS connection error and would never get to this captured response

@snehachhabria
Copy link
Contributor Author

looks sufficient to capture the certs a backend may be presenting, i'm curious how this will be used in practice since there aren't any tests making assertions on this? I might be missing some context that needs to be added to the original issue, but if a backend is presenting an unexpected cert for example, we would likely get a TLS connection error and would never get to this captured response

currently there are no tests in the conformance that are asserting on this, exposing this will allow the extension of tests to make these assertions as well. That's right if an unexpected cert is provided there will be a TLS connection error and there is no need to validate the cert in that scenario but for success scenarios additional validation will help assert the cert details.

This was discussed in the meeting on Monday, I've added more context to the issue. Hope all this helps

@snehachhabria
Copy link
Contributor Author

@sunjayBhatia if this PR looks good can it be merged ?

@robscott
Copy link
Member

robscott commented Jun 3, 2024

Thanks @snehachhabria, I think this is likely going to be helpful as we build out more Backend mTLS capabilities in the API. In the meantime, I think it's reasonable to let this in for anyone using this framework for broader test cases. Will defer to someone else for LGTM though.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, snehachhabria

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/test release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants