Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update and refactor contribution part #5073

Merged
merged 7 commits into from
Feb 8, 2025

Conversation

ivankatliarchuk
Copy link
Contributor

@ivankatliarchuk ivankatliarchuk commented Feb 7, 2025

Description

No issue. Added documentation with developer guide on minikube, how to generate docs and etc.

Slightly tweaked description of a flag. Slack discussion https://kubernetes.slack.com/archives/C771MKDKQ/p1738846183673949

Checklist

  • Unit tests updated
  • End user documentation updated

Signed-off-by: ivan katliarchuk <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 7, 2025
@k8s-ci-robot k8s-ci-robot requested a review from szuecs February 7, 2025 12:03
@ivankatliarchuk
Copy link
Contributor Author

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 7, 2025
Signed-off-by: ivan katliarchuk <[email protected]>
Signed-off-by: ivan katliarchuk <[email protected]>
Signed-off-by: ivan katliarchuk <[email protected]>
docs/flags.md Outdated Show resolved Hide resolved
@mloiseleur
Copy link
Contributor

Thanks for this PR 👍 It LGTM.
See my suggestion for a minor edit on help.

@mloiseleur
Copy link
Contributor

/retitle "docs: update and refactor contribution part"

@k8s-ci-robot k8s-ci-robot changed the title docs: updated/added/modified contribution docs "docs: update and refactor contribution part" Feb 8, 2025
@mloiseleur
Copy link
Contributor

/retitle docs: update and refactor contribution part

@k8s-ci-robot k8s-ci-robot changed the title "docs: update and refactor contribution part" docs: update and refactor contribution part Feb 8, 2025
ivankatliarchuk and others added 3 commits February 8, 2025 14:16
Co-authored-by: Michel Loiseleur <[email protected]>
* master:
  fix(chart): update rbac for F5 transportserver source (kubernetes-sigs#5066)
  fix(chart): non-string types on svcaccount annotations (kubernetes-sigs#5067)
Signed-off-by: ivan katliarchuk <[email protected]>
@mloiseleur
Copy link
Contributor

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mloiseleur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 8, 2025
@k8s-ci-robot k8s-ci-robot merged commit e7ff1c9 into kubernetes-sigs:master Feb 8, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants