fix(chart): non-string types on svcaccount annotations (#5067)

* added toYaml to convert non-string types to yaml/string types Signed-off-by: hjoshi123 <[email protected]> * fix: added PR url and number annotation --------- Signed-off-by: hjoshi123 <[email protected]>
kubernetes-sigs · Feb 7, 2025 · c88150b · c88150b
1 parent cdbffbb
commit c88150b
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/charts/external-dns/CHANGELOG.md b/charts/external-dns/CHANGELOG.md
@@ -18,6 +18,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [UNRELEASED]
 
+### Fixed
+
+- Fixed handling of non-string types in `serviceAccount.metadata.annotations` field. ([#5067](https://github.com/kubernetes-sigs/external-dns/pull/5067)) _@hjoshi123_
+
 ## [v1.15.1] - 2023-09-10
 
 ### Added

diff --git a/charts/external-dns/ci/ci-values.yaml b/charts/external-dns/ci/ci-values.yaml
@@ -40,3 +40,5 @@ serviceAccount:
     notTemplated/version: "v1.2.3"
     justValueTemplated/version: "{{ .Chart.Version }}"
     "{{ .Chart.Name }}/chart": "{{ .Chart.Version }}"
+    booleanVersion: "true"
+    number: "1"
diff --git a/charts/external-dns/templates/serviceaccount.yaml b/charts/external-dns/templates/serviceaccount.yaml
@@ -12,7 +12,7 @@ metadata:
   {{- with .Values.serviceAccount.annotations }}
   annotations:
     {{- range $k, $v := . }}
-      {{- printf "%s: %s" (tpl $k $) (tpl $v $) | nindent 4 }}
+      {{- printf "%s: %s" (toYaml (tpl $k $)) (toYaml (tpl $v $)) | nindent 4 }}
     {{- end }}
   {{- end }}
 automountServiceAccountToken: {{ .Values.serviceAccount.automountServiceAccountToken }}