fix removepodsviolatingtopologyspreadconstraint plugin sort logic #1629
Conversation
…tingtopologyspreadconstraint plugin sort logic
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
size/S
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| // true - j is non-evictable, so return false to put j before i | ||
| // if true and both and non-evictable, order doesn't matter | ||
| return !(isEvictable(list[i]) && !isEvictable(list[j])) | ||
| // i is non-evictable and should come before j |
There was a problem hiding this comment.
I understand that this is easier to read.
| @@ -416,19 +416,26 @@ func sortDomains(constraintTopologyPairs map[topologyPair][]*v1.Pod, isEvictable | |||
| // followed by the lowest priority pods with affinity or nodeSelector, | |||
| // followed by the highest priority pods with affinity or nodeSelector | |||
| sort.Slice(list, func(i, j int) bool { | |||
| evictableI := isEvictable(list[i]) | |||
There was a problem hiding this comment.
we should call isEvictable only once
|
@a7i @ingvagabund can you help this? |
Fix: #1624