Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nodeutilization]: allow to set a metrics source as an enum so it can be later extended for exclusive configuration #1614

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[nodeutilization]: allow to set a metrics source as an enum so it can be later extended for exclusive configuration #1614

wants to merge 1 commit into from

Conversation

ingvagabund
Copy link
Contributor

Introducing an enum will restrict a metrics sources to a single source without extra validation.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from ingvagabund. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 27, 2025
@ingvagabund
[nodeutilization]: allow to set a metrics source as an enum so it can…
6970000 
… be later extended for exclusive configuration

Introducing an enum will restrict a metrics sources to a single source
without extra validation.
@ingvagabund ingvagabund force-pushed the nodeutilization-metrics-source branch from c5ec797 to 6970000 Compare January 27, 2025 11:15
@ingvagabund
Copy link
Contributor Author

/hold
for now given https://github.com/kubernetes-sigs/descheduler/releases/tag/v0.32.1 is already out.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 27, 2025
@k8s-ci-robot
Copy link
Contributor

@ingvagabund: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-descheduler-verify-master 6970000 link true /test pull-descheduler-verify-master
pull-descheduler-verify-build-master 6970000 link true /test pull-descheduler-verify-build-master
pull-descheduler-test-e2e-k8s-master-1-31 6970000 link true /test pull-descheduler-test-e2e-k8s-master-1-31
pull-descheduler-test-e2e-k8s-master-1-32 6970000 link true /test pull-descheduler-test-e2e-k8s-master-1-32
pull-descheduler-unit-test-master-master 6970000 link true /test pull-descheduler-unit-test-master-master
pull-descheduler-test-e2e-k8s-master-1-30 6970000 link true /test pull-descheduler-test-e2e-k8s-master-1-30

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damemi damemi Awaiting requested review from damemi

@knelasevero knelasevero Awaiting requested review from knelasevero

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ingvagabund @k8s-ci-robot