Move values.yaml comment about defining your own configmap to a NOTES.txt output instead

[tspearconquest]

This PR intends to make the chart easier to use by providing clear instructions visible to the user after an install. I found the comment in values.yaml to be confusing and ultimately made a PR in error trying to fix something which wasn't broken, so I hope that this PR will be found to be useful and more helpful, not to mention visible.

[k8s-ci-robot]

Hi @tspearconquest. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[a7i]

/ok-to-test

[a7i]

/lgtm

[tspearconquest]

Just a quick response from my email tied to the PR to confirm that the other comment by @Speeddymon was, in fact, me.

…

On Tue, Jan 7, 2025, 11:19 AM Thomas Spear ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In charts/descheduler/templates/NOTES.txt <#1582 (comment)> : > @@ -10,3 +10,13 @@ WARNING: You enabled DryRun mode, you can't use Leader Election. {{- end}} {{- end}} {{- end}} +{{- if .Values.deschedulerPolicy }} +A default DeschedulerPolicy has been applied for you. You can view the policy with: Indeed. We can remove the "default" from the line. Unfortunately the system I develop on is down at the moment so I can't make this amendment until I do an OS reinstall this upcoming weekend. — Reply to this email directly, view it on GitHub <#1582 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ATRTFZ4HV7F3CX5CTGNSZ4L2JQEBHAVCNFSM6AAAAABUBKTPISVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMZUHE3TGOJVGM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[k8s-ci-robot]

New changes are detected. LGTM label has been removed.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from a7i. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tspearconquest]

I've removed the mention of "default" as requested.