Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new templates examples for Talos and Flatcar #300

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gcezaralmeida
Copy link

Signed-off-by: Gabriel Almeida [email protected]

Signed off the changes

What this PR does / why we need it:
Add new templates examples for Talos and Flatcar.

Which issue this PR fixes : fixes #298

Special notes for your reviewer:

Release notes:

@qinqon

Signed-off-by: Gabriel Almeida <[email protected]>

Signed off the changes
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 29, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @gcezaralmeida!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-kubevirt 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-kubevirt has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 29, 2024
@agradouski
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 10, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12089201240

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 59.245%

Totals Coverage Status
Change from base Build 11667377340: 0.0%
Covered Lines: 1570
Relevant Lines: 2650

💛 - Coveralls

@gcezaralmeida
Copy link
Author

@qinqon Can you approve?

Copy link
Contributor

@qinqon qinqon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gcezaralmeida, qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2025
@nunnatsa
Copy link
Contributor

/cancel lgtm
Let's make sure that ci pass

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 21, 2025
@nunnatsa
Copy link
Contributor

nunnatsa commented Jan 21, 2025

build/make-gen lane is failing.

@gcezaralmeida - please run

make check-gen 

It will generate 4 new files under templates/. Please add these new files to your PR.

@nunnatsa nunnatsa removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 21, 2025
@nunnatsa
Copy link
Contributor

@gcezaralmeida - please look at #302 - and this comment.

WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve templates with FlatCar and Talos examples
6 participants