Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 test: e2e: make managed suite more robust to errors with Eventually() #5215

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

damdo
Copy link
Member

@damdo damdo commented Nov 13, 2024

What type of PR is this?
/kind flake

What this PR does / why we need it:
make managed suite more robust to errors with Eventually()

Special notes for your reviewer:
Trying to address issues like the ones seen here: https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_cluster-api-provider-aws/5211/pull-cluster-api-provider-aws-e2e-eks/1856371404925046784

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/flake Categorizes issue or PR as related to a flaky test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 13, 2024
@k8s-ci-robot k8s-ci-robot added needs-priority size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 13, 2024
@damdo
Copy link
Member Author

damdo commented Nov 13, 2024

/assign @richardcase @nrb

@damdo
Copy link
Member Author

damdo commented Nov 13, 2024

/test ?

@k8s-ci-robot
Copy link
Contributor

@damdo: The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-aws-build
  • /test pull-cluster-api-provider-aws-build-docker
  • /test pull-cluster-api-provider-aws-test
  • /test pull-cluster-api-provider-aws-verify

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-aws-apidiff-main
  • /test pull-cluster-api-provider-aws-e2e
  • /test pull-cluster-api-provider-aws-e2e-blocking
  • /test pull-cluster-api-provider-aws-e2e-clusterclass
  • /test pull-cluster-api-provider-aws-e2e-conformance
  • /test pull-cluster-api-provider-aws-e2e-conformance-with-ci-artifacts
  • /test pull-cluster-api-provider-aws-e2e-eks
  • /test pull-cluster-api-provider-aws-e2e-eks-gc
  • /test pull-cluster-api-provider-aws-e2e-eks-testing

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-aws-apidiff-main
  • pull-cluster-api-provider-aws-build
  • pull-cluster-api-provider-aws-build-docker
  • pull-cluster-api-provider-aws-test
  • pull-cluster-api-provider-aws-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@damdo
Copy link
Member Author

damdo commented Nov 13, 2024

/test pull-cluster-api-provider-aws-e2e-eks

@damdo
Copy link
Member Author

damdo commented Nov 13, 2024

Failed is unrelated (due to AWS CloudFormation stack)

/test pull-cluster-api-provider-aws-e2e-eks

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from nrb. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@damdo
Copy link
Member Author

damdo commented Nov 13, 2024

/test pull-cluster-api-provider-aws-e2e-eks

2 similar comments
@damdo
Copy link
Member Author

damdo commented Nov 13, 2024

/test pull-cluster-api-provider-aws-e2e-eks

@damdo
Copy link
Member Author

damdo commented Nov 14, 2024

/test pull-cluster-api-provider-aws-e2e-eks

@damdo
Copy link
Member Author

damdo commented Nov 14, 2024

/test pull-cluster-api-provider-aws-test

@damdo
Copy link
Member Author

damdo commented Nov 14, 2024

/test pull-cluster-api-provider-aws-e2e-eks

1 similar comment
@damdo
Copy link
Member Author

damdo commented Nov 14, 2024

/test pull-cluster-api-provider-aws-e2e-eks

@damdo
Copy link
Member Author

damdo commented Nov 14, 2024

/test pull-cluster-api-provider-aws-e2e-eks

1 similar comment
@damdo
Copy link
Member Author

damdo commented Nov 15, 2024

/test pull-cluster-api-provider-aws-e2e-eks

@damdo
Copy link
Member Author

damdo commented Nov 15, 2024

/test pull-cluster-api-provider-aws-e2e-eks

@damdo
Copy link
Member Author

damdo commented Nov 15, 2024

AWS Cloud formation stack timed out

/test pull-cluster-api-provider-aws-e2e-eks

@damdo
Copy link
Member Author

damdo commented Nov 15, 2024

/test pull-cluster-api-provider-aws-e2e-eks

@k8s-ci-robot
Copy link
Contributor

@damdo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-aws-e2e-eks c0c1125 link false /test pull-cluster-api-provider-aws-e2e-eks

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@damdo
Copy link
Member Author

damdo commented Nov 15, 2024

@richardcase do you have any idea on why waiting for addons fails so often?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. needs-priority release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants