-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add AWSMachines to back the EC2 instances in AWSMachinePools and AWSManagedMachinePools #5174
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
99a1613
to
bc8557a
Compare
@AndiDog - it would be good to discuss this in office hours. I'm not sure about including |
…anagedMachinePools Co-authored-by: Cameron McAvoy <[email protected]>
Agree. I also didn't test EKS yet. Meanwhile, I'll anyway push a change to separate out the common functions, and rebase onto |
bc8557a
to
bb313f7
Compare
What type of PR is this?
/kind feature
What this PR does / why we need it:
This implements the CAPI MachinePool Machines proposal.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #4184
Special notes for your reviewer:
Revival of #4527. I took @cnmcavoy's great effort and got it fully working. I tested EC2 cluster creation, machine deletion by user, instance creation and termination by ASG scaling, instance termination by user, ...
Checklist:
Release note: