Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add AWSMachines to back the EC2 instances in AWSMachinePools and AWSManagedMachinePools #5174

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

AndiDog
Copy link
Contributor

@AndiDog AndiDog commented Oct 22, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

This implements the CAPI MachinePool Machines proposal.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #4184

Special notes for your reviewer:

Revival of #4527. I took @cnmcavoy's great effort and got it fully working. I tested EC2 cluster creation, machine deletion by user, instance creation and termination by ASG scaling, instance termination by user, ...

Checklist:

  • squashed commits
  • includes documentation
  • includes emojis
  • adds unit tests
  • adds or updates e2e tests

Release note:

Add AWSMachines to back the EC2 instances in AWSMachinePools and AWSManagedMachinePools

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Oct 22, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from andidog. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 22, 2024
@AndiDog AndiDog changed the title Add AWSMachines to back the EC2 instances in AWSMachinePools and AWSManagedMachinePools ✨ Add AWSMachines to back the EC2 instances in AWSMachinePools and AWSManagedMachinePools Oct 22, 2024
@richardcase
Copy link
Member

@AndiDog - it would be good to discuss this in office hours. I'm not sure about including AWSManagedMachinePools in this.

@AndiDog
Copy link
Contributor Author

AndiDog commented Oct 23, 2024

@AndiDog - it would be good to discuss this in office hours. I'm not sure about including AWSManagedMachinePools in this.

Agree. I also didn't test EKS yet.

Meanwhile, I'll anyway push a change to separate out the common functions, and rebase onto main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement MachinePool Machines clusterAPI proposal
3 participants