🐛 Remove Old Mapped ARNs #4919
🐛 Remove Old Mapped ARNs #4919
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
kind/bug
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
|
Hi @wcrum. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
ok-to-test
Signed-off-by: Will <[email protected]> fix: remove white space for linter Signed-off-by: Will <[email protected]>
|
@wcrum Thanks for your PR and your patience. I think this is a reasonable change. The only thing I think is missing is a test case that demonstrates the desired behavior from the issue; that is, having existing users and updating to remove one (or more). |
|
@wcrum would you be able to add such test? Thanks! |
|
Added additional tests to MapUsers to verify expected, existing and additional mappings. |
|
@wcrum are the failures in the |
|
Failure https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-aws/4919/pull-cluster-api-provider-aws-apidiff-main/1803839875892383744 is related to required changes to the CAPA API Schema as it introduces new functions. Other one I'm not too sure. |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
k8s-ci-robot
added
the
lifecycle/stale
|
/remove-lifecycle stale |
k8s-ci-robot
removed
the
lifecycle/stale
|
/retest |
|
@wcrum: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Just following back here - I previously did add tests, existing failures are due to apidiff. This is still an issue. |
|
Could you rebase @wcrum ? |
What type of PR is this?
Bug fix to reference #4740.
/kind bug
What this PR does / why we need it:
This PR fixes the issue where old ARNs are not removed within
kube-system/aws-auth. We need this for security purposes.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #4740.
Special notes for your reviewer:
Checklist:
Release note: