Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]feat: support original workload identity for blobfuse2 #1673

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cvvz
Copy link
Member

@cvvz cvvz commented Nov 5, 2024

What type of PR is this?
/kind feature

What this PR does / why we need it:
The previous implementation of supporting workload identity is to use workload identity to retrieve account key for mounting. Since blobfuse2 has supported workload identity authentication, we can use workload identity to directly mount without retrieving account key.
Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

feat: support original workload identity for blobfuse2 (without retrieve account key)

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cvvz
Once this PR has been reviewed and has the lgtm label, please assign feiskyer for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 5, 2024
@cvvz cvvz changed the title feat: support workload identity for blobfuse2 [WIP]feat: support workload identity for blobfuse2 Nov 5, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 5, 2024
@cvvz
Copy link
Member Author

cvvz commented Nov 5, 2024

We need to merge Azure/azure-storage-fuse#1556 first and wait for the latest blobfuse2 release and update the docker file and Agent-baker to install the latest blobfuse2 release.

@cvvz cvvz changed the title [WIP]feat: support workload identity for blobfuse2 [WIP]feat: support original workload identity for blobfuse2 Nov 5, 2024
@k8s-ci-robot
Copy link
Contributor

@cvvz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-blob-csi-driver-external-e2e-blobfuse-v2 b61d0d3 link true /test pull-blob-csi-driver-external-e2e-blobfuse-v2
pull-blob-csi-driver-external-e2e-nfs b61d0d3 link true /test pull-blob-csi-driver-external-e2e-nfs
pull-blob-csi-driver-external-e2e-blobfuse b61d0d3 link true /test pull-blob-csi-driver-external-e2e-blobfuse
pull-blob-csi-driver-e2e b61d0d3 link true /test pull-blob-csi-driver-e2e
pull-blob-csi-driver-e2e-proxy b61d0d3 link true /test pull-blob-csi-driver-e2e-proxy

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 13, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants