Skip to content

refactor: making tests configurable to run on eks auto framework - #4891

Merged
kubernetes-prow[bot] merged 4 commits into
kubernetes-sigs:mainfrom
jupdec:eks-auto-tests-v2
Sep 1, 2026
Merged

refactor: making tests configurable to run on eks auto framework#4891
kubernetes-prow[bot] merged 4 commits into
kubernetes-sigs:mainfrom
jupdec:eks-auto-tests-v2

Conversation

@jupdec

@jupdec jupdec commented Aug 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Issue

Minor test framework updates to reuse this test suite for Auto Mode

Description

  1. Making GatewayClass controllerName configurable
  2. Extracting InitTF and rename Describe files for cross-package import
  3. Skiping UDP verify on IPv4 clusters

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

jupdec added 3 commits August 31, 2026 19:02
@jupdec
e2e/gateway: make GatewayClass controllerName configurable
1cb172b 
Callers consult test_resources.{ALB,NLB}GatewayControllerName instead of
hardcoded strings. Defaults preserve upstream behavior; override via
GATEWAY_{ALB,NLB}_CONTROLLER_NAME env for forks that rebrand.
@jupdec
e2e/gateway: extract InitTF and rename Describe files for cross-packa…
17b9e60 
…ge import

Blank-importing from a parent test binary requires Describes in regular
.go files (Go excludes _test.go from cross-package imports). Each suite
exposes state.go with InitTF() and moves specs to non-test files.
@jupdec
e2e/gateway: skip UDP verify on IPv4 clusters
9bb1ef3 
AWS locks preserve_client_ip=true for UDP/TCP_UDP target groups (verified
via ModifyTargetGroupAttributes). With client IP preserved, udp-echoserver
replies bypass the NLB return path and the client times out. The IPv6
SourceNatIPv6Prefix workaround has no IPv4 equivalent in the CRD, so skip
the assertion on IPv4.
@kubernetes-prow kubernetes-prow Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 31, 2026
@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 31, 2026
@kubernetes-prow

kubernetes-prow Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Hi @jupdec. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 31, 2026
@jupdec
jupdec marked this pull request as ready for review August 31, 2026 19:19
@kubernetes-prow kubernetes-prow Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 31, 2026
@kubernetes-prow
kubernetes-prow Bot requested a review from oliviassss August 31, 2026 19:20
@jupdec
jupdec marked this pull request as draft August 31, 2026 19:47
@kubernetes-prow kubernetes-prow Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 31, 2026
@jupdec
jupdec marked this pull request as ready for review August 31, 2026 20:44
@kubernetes-prow kubernetes-prow Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 31, 2026
@kubernetes-prow
kubernetes-prow Bot requested a review from wweiwei-li August 31, 2026 20:44
shraddhabang
shraddhabang approved these changes Aug 31, 2026
View reviewed changes

@shraddhabang shraddhabang left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 31, 2026
@kubernetes-prow

kubernetes-prow Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jupdec, shraddhabang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2026
@jupdec
e2e: init sibling gateway tf in cross-importing suites
84e31c0 
Suites blank-importing alb_tests/nlb_tests transitively register those
packages' Describes into the test binary; without calling their InitTF
the imported BeforeEach nil-derefs on tf.Options.
@kubernetes-prow kubernetes-prow Bot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 1, 2026
@jupdec

jupdec commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@kubernetes-prow

kubernetes-prow Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

@jupdec: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov-commenter

codecov-commenter commented Sep 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.48%. Comparing base (2fcd20d) to head (84e31c0).
⚠️ Report is 22 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4891      +/-   ##
==========================================
+ Coverage   57.44%   57.48%   +0.03%     
==========================================
  Files         396      397       +1     
  Lines       31619    31709      +90     
==========================================
+ Hits        18164    18228      +64     
- Misses      12398    12422      +24     
- Partials     1057     1059       +2

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shraddhabang

shraddhabang commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

/lgtm

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 1, 2026
@kubernetes-prow
kubernetes-prow Bot merged commit ff98381 into kubernetes-sigs:main Sep 1, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shraddhabang shraddhabang shraddhabang approved these changes
@zac-nixon zac-nixon Awaiting requested review from zac-nixon
@oliviassss oliviassss Awaiting requested review from oliviassss
@wweiwei-li wweiwei-li Awaiting requested review from wweiwei-li

Assignees

@shraddhabang shraddhabang

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jupdec @codecov-commenter @shraddhabang