Skip to content

refactor: Allow automode controllers to customize the gateway controller - #4887

Merged
zac-nixon merged 4 commits into
kubernetes-sigs:mainfrom
zac-nixon:main
Aug 27, 2026
Merged

refactor: Allow automode controllers to customize the gateway controller#4887
zac-nixon merged 4 commits into
kubernetes-sigs:mainfrom
zac-nixon:main

Conversation

@zac-nixon

@zac-nixon zac-nixon commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

Issue

Description

Key changes:

Makes the Gateway stack deployer and tracking provider injectable instead of constructing them internally.
Adds reconcile success/error callbacks for Gateway API controllers.
Makes Gateway controller setup more reusable between ALB and NLB implementations.
Fixes Gateway API CRD detection to require ReferenceGrant.
Removes the no-longer-needed v1beta1 Gateway API scheme registration.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 26, 2026
@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2026
@codecov-commenter

codecov-commenter commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 21.62162% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.48%. Comparing base (057c70f) to head (637849d).
⚠️ Report is 31 commits behind head on main.

Files with missing lines Patch % Lines
controllers/gateway/gateway_controller.go 0.00% 10 Missing ⚠️
...s/gateway/listenerrule_configuration_controller.go 0.00% 5 Missing ⚠️
...s/gateway/loadbalancer_configuration_controller.go 0.00% 5 Missing ⚠️
...rs/gateway/targetgroup_configuration_controller.go 0.00% 5 Missing ⚠️
controllers/gateway/gateway_class_controller.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4887      +/-   ##
==========================================
- Coverage   57.49%   57.48%   -0.01%     
==========================================
  Files         396      397       +1     
  Lines       31621    31708      +87     
==========================================
+ Hits        18179    18227      +48     
- Misses      12384    12422      +38     
- Partials     1058     1059       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wweiwei-li, zac-nixon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [wweiwei-li,zac-nixon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zac-nixon
zac-nixon merged commit 7040d02 into kubernetes-sigs:main Aug 27, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants