refactor: Allow automode controllers to customize the gateway controller - #4887
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4887 +/- ##
==========================================
- Coverage 57.49% 57.48% -0.01%
==========================================
Files 396 397 +1
Lines 31621 31708 +87
==========================================
+ Hits 18179 18227 +48
- Misses 12384 12422 +38
- Partials 1058 1059 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
wweiwei-li
approved these changes
Aug 26, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wweiwei-li, zac-nixon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Description
Key changes:
Makes the Gateway stack deployer and tracking provider injectable instead of constructing them internally.
Adds reconcile success/error callbacks for Gateway API controllers.
Makes Gateway controller setup more reusable between ALB and NLB implementations.
Fixes Gateway API CRD detection to require ReferenceGrant.
Removes the no-longer-needed v1beta1 Gateway API scheme registration.
Checklist
README.md, or thedocsdirectory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯