feat: make leader election lease duration configurable

[Dasmat13]

Closes #3823.

This PR implements a configurable leaseDurationSeconds for the AWS Load Balancer Controller by introducing an opt-in command-line flag (--leader-election-lease-duration) and updating the Helm chart values/templates/README.

Changes:

• Added --leader-election-lease-duration flag to the controller manager.
• Designed the flag to be strictly opt-in (omitting it retains controller-runtime's built-in defaults, as requested by maintainers).
• Added leaderElectionLeaseDuration to the Helm values and templates, and documented it in the README.
• Added unit tests in pkg/config/runtime_config_test.go to test the options building logic.

[kubernetes-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Dasmat13
Once this PR has been reviewed and has the lgtm label, please assign oliviassss for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kubernetes-prow]

Welcome @Dasmat13!

It looks like this is your first PR to kubernetes-sigs/aws-load-balancer-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-load-balancer-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[kubernetes-prow]

Hi @Dasmat13. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Dasmat13]

Hi @oliviassss and @wweiwei-li 👋

When you have a chance, could you please take a look at this PR? It also needs /ok-to-test before the required CI jobs can run.

The implementation keeps the feature opt-in, so existing behavior remains unchanged unless --leader-election-lease-duration is explicitly configured. Happy to make any changes based on your feedback. Thanks!

[Dasmat13]

Hi @oliviassss @wweiwei-li, quick ping on this PR. It’s still waiting for /ok-to-test before CI can run. Could you take a look when you get a chance? Thanks

[wweiwei-li]

/ok-to-test

[codecov-commenter]

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.57%. Comparing base (82c3870) to head (91b1097).
⚠️ Report is 79 commits behind head on main.

Files with missing lines	Patch %	Lines
pkg/config/runtime_config.go	50.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4842      +/-   ##
==========================================
+ Coverage   57.08%   57.57%   +0.49%     
==========================================
  Files         396      396              
  Lines       31572    31625      +53     
==========================================
+ Hits        18022    18209     +187     
+ Misses      12492    12355     -137     
- Partials     1058     1061       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.