fix sorting when comparing listener rule differences

[zac-nixon]

Description

Anytime the Ingress reconcilation process runs, it can potentially modify all ALB rules. This is because in v2.12.0 we broke the listener rule conditions sorting, which prevented semantically similar configurations to be detected as drifted. As listener rule conditions can be returned in any order, the reconcilation process could potentially say a configuration like:

				{
					Field: awssdk.String("host-header"),
					HostHeaderConfig: &types.HostHeaderConditionConfig{
						Values: []string{"h1"},
					},
				},
				{
					Field: awssdk.String("path-pattern"),
					PathPatternConfig: &types.PathPatternConditionConfig{
						Values: []string{"path-pattern"},
					},
				},

is not equal to

				{
					Field: awssdk.String("path-pattern"),
					PathPatternConfig: &types.PathPatternConditionConfig{
						Values: []string{"path-pattern"},
					},
				},
				{
					Field: awssdk.String("host-header"),
					HostHeaderConfig: &types.HostHeaderConditionConfig{
						Values: []string{"h1"},
					},
				},

The root cause that broke the sorting is that we started using the actual condition / action objects in the array, rather than a pointer. e.g. originally the code was comparing arrays of []*elbv2types.RuleCondition, but it v2.12 this was refactored to compare arrays of []elbv2types.RuleCondition while the compartator was still expecting a *elbv2types.RuleCondition. I fixed the comparator to use the right type. Also, I added some compile time checks and warnings to ensure this doesn't happen again.

Checklist

• Added tests that cover your change (if possible)
• Added/modified documentation as required (such as the README.md, or the docs directory)
• Manually tested
• Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

• Backfilled missing tests for code in same general area 🎉
• Refactored something and made the world a better place 🌟

[shuqz]

/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shuqz, zac-nixon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [zac-nixon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[shraddhabang]

/lgtm