-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Update K8s version support #4266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: realjoshparker The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @realjoshparker! |
Hi @realjoshparker. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/lgtm thanks for doing this! |
/retest |
/retest |
@realjoshparker: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Issue
N/A
Description
Update the version support docs so
v2.0.0~v2.1.3
ends support onv1.21
of K8s. The current state of the docs indicate that these versions of the controller support K8sv1.15+
which is incorrect as they rely on thenetworking.k8s.io/v1beta1
API, which was removed in K8s v1.22. Below is a few log lines from myv1.32
cluster confirmingv2.1.3
of the controller is using the removed API versionFurther according to this comment on issue #2495 support for the GA version of this API wasn't added until
v2.4.0
of the controller and therefore this should have a similar end of support forv1.21
of K8s like thev2.2.0~v2.3.1
versions.Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯