Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable http and https listener attributes #3948

Merged

Conversation

wweiwei-li
Copy link
Collaborator

Description

  • Improvement: setting attributes on IngressClassParam should resolve the conflicts in ingress group.
  • Enabled Http and Https listener attributes. alb.ingress.kubernetes.io/listener-attributes.${Protocol}-{Port} annotation, which allows dynamically configuration of protocol and port. With the combination of protocol and port, it serves as a unique identifier, enabling us to identify the listener and set attributes to it accordingly. For example, set
    alb.ingress.kubernetes.io/listener-attributes.HTTPS-443 : routing.http.response.server.enabled=true.
  • Also, new IngressClassParams spec listeners, allowing set listener attributes at ingress class level. For example
  listeners:
    - protocol: HTTPS
      port: 443
      listenerAttributes:
        - key: routing.http.response.server.enabled
          value: "true"

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 21, 2024
@shraddhabang
Copy link
Collaborator

/lgtm
/approved

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 21, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wweiwei-li, zac-nixon
Once this PR has been reviewed and has the lgtm label, please assign m00nf1sh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wweiwei-li wweiwei-li merged commit 8ba34e2 into kubernetes-sigs:main Nov 21, 2024
8 of 9 checks passed
shraddhabang pushed a commit to shraddhabang/aws-load-balancer-controller that referenced this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants