-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add check for LB availability to e2e #3343
Conversation
/retest |
/retest |
The suite is timing out. Perhaps the timeout in scripts/run-e2e-test.sh needs to be increased? |
@johngmyers, thank you! I was just aware that ginkgo v2 change the default timeout from 24h to 1h. I have updated the timeout to 2h, let's see how it works this time. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #3343 +/- ##
=======================================
Coverage 55.61% 55.61%
=======================================
Files 149 149
Lines 8819 8819
=======================================
Hits 4905 4905
Misses 3577 3577
Partials 337 337 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: M00nF1sh, oliviassss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue
Description
Add a step to wait for the NLB to be available before proceeding to any resource deletions, to some test suites that were lacking this check. For the below reasons:
Test:
Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯