Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for LB availability to e2e #3343

Merged
merged 4 commits into from
Aug 21, 2023

Conversation

oliviassss
Copy link
Collaborator

@oliviassss oliviassss commented Aug 16, 2023

Issue

Description

Add a step to wait for the NLB to be available before proceeding to any resource deletions, to some test suites that were lacking this check. For the below reasons:

  • There's a limit from ELB side that if we delete the SG before NLB configuration finishes, it will cause an issue and may put the internal metrics on fire, and ELB is working on adding an error message to this.
  • We should check the LB status no matter whether we are doing traffic test or just validating the configurations.

Test:

  • Ran the e2e test in my dev cluster and verified all test suites passed.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 16, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 16, 2023
@oliviassss
Copy link
Collaborator Author

/retest

@oliviassss
Copy link
Collaborator Author

/retest

@johngmyers
Copy link
Contributor

The suite is timing out. Perhaps the timeout in scripts/run-e2e-test.sh needs to be increased?

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 18, 2023
@oliviassss
Copy link
Collaborator Author

@johngmyers, thank you! I was just aware that ginkgo v2 change the default timeout from 24h to 1h. I have updated the timeout to 2h, let's see how it works this time.

scripts/ci_e2e_test.sh Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (aa893b5) 55.61% compared to head (8c91aab) 55.61%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3343   +/-   ##
=======================================
  Coverage   55.61%   55.61%           
=======================================
  Files         149      149           
  Lines        8819     8819           
=======================================
  Hits         4905     4905           
  Misses       3577     3577           
  Partials      337      337           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oliviassss oliviassss changed the title wait for the TG to be healthy before cleanup any resource Add check for LB availability to e2e Aug 21, 2023
Copy link
Collaborator

@M00nF1sh M00nF1sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: M00nF1sh, oliviassss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2023
@k8s-ci-robot k8s-ci-robot merged commit 3e8fea3 into kubernetes-sigs:main Aug 21, 2023
2 checks passed
@oliviassss oliviassss added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 21, 2023
@johngmyers johngmyers mentioned this pull request Aug 23, 2023
12 tasks
@oliviassss oliviassss deleted the e2e-fix branch August 28, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants