Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check the canary test result and exit if it failed #3335

Merged
merged 1 commit into from
Aug 14, 2023
Merged

check the canary test result and exit if it failed #3335

merged 1 commit into from
Aug 14, 2023

Conversation

oliviassss
Copy link
Collaborator

@oliviassss oliviassss commented Aug 11, 2023 •
edited
Loading

Issue

Description

Check and store the canary test result and exit if it failed.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 11, 2023
M00nF1sh
M00nF1sh approved these changes Aug 11, 2023
View reviewed changes
Copy link
Collaborator

@M00nF1sh M00nF1sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 11, 2023
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (35126b2) 55.61% compared to head (88974f5) 55.61%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3335   +/-   ##
=======================================
  Coverage   55.61%   55.61%           
=======================================
  Files         149      149           
  Lines        8819     8819           
=======================================
  Hits         4905     4905           
  Misses       3577     3577           
  Partials      337      337

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oliviassss
Copy link
Collaborator Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 11, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 14, 2023
@oliviassss oliviassss changed the title disable NLB SG for internal cananry job check the canary test result and exit if it failed Aug 14, 2023
jdn5126
jdn5126 reviewed Aug 14, 2023
View reviewed changes
scripts/run-e2e-test.sh Outdated Show resolved Hide resolved
@jdn5126
Copy link
Contributor

jdn5126 commented Aug 14, 2023

/lgtm

@k8s-ci-robot
Copy link
Contributor

@jdn5126: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@oliviassss oliviassss removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 14, 2023
M00nF1sh
M00nF1sh approved these changes Aug 14, 2023
View reviewed changes
Copy link
Collaborator

@M00nF1sh M00nF1sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 14, 2023
@M00nF1sh
Copy link
Collaborator

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jdn5126, M00nF1sh, oliviassss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit aa893b5 into kubernetes-sigs:main Aug 14, 2023
2 checks passed
@oliviassss oliviassss deleted the canary-fix branch August 28, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M00nF1sh M00nF1sh M00nF1sh approved these changes

@jdn5126 jdn5126 jdn5126 approved these changes

@kishorj kishorj Awaiting requested review from kishorj

Assignees

@M00nF1sh M00nF1sh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oliviassss @codecov-commenter @jdn5126 @k8s-ci-robot @M00nF1sh