Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update live docs for NLB-SG feature release #3332

Merged
merged 4 commits into from
Aug 14, 2023
Merged

Update live docs for NLB-SG feature release #3332

merged 4 commits into from
Aug 14, 2023

Conversation

shraddhabang
Copy link
Collaborator

Issue

Update the live docs for NLB-SG feature

Description

Update the live docs for NLB-SG feature
Release Note : https://github.com/kubernetes-sigs/aws-load-balancer-controller/releases/tag/v2.6.0

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 10, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @shraddhabang. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 10, 2023
oliviassss
oliviassss reviewed Aug 10, 2023
View reviewed changes
docs/guide/service/annotations.md Outdated
@@ -448,7 +452,23 @@ Load balancer access can be controlled via following annotations:
```
service.beta.kubernetes.io/aws-load-balancer-internal: "true"
```
- <a name="security-groups">`service.beta.kubernetes.io/aws-load-balancer-security-groups`</a> specifies the securityGroups you want to attach to NLB.
Copy link
Collaborator

@oliviassss oliviassss Aug 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: may be "specifies the frontend securityGroups you want to attach to NLB", and also please improve the annotation on ALB side to specify it's for frontend SG

@oliviassss
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 10, 2023
@johngmyers
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 11, 2023
@johngmyers
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 11, 2023
@shraddhabang
Copy link
Collaborator Author

@johngmyers Thank you for all the suggestions. I have added that to a commit. Please take a look

@johngmyers
Copy link
Contributor

/retest

@johngmyers
Copy link
Contributor

@shraddhabang I see you didn't take all of the suggestions. Did you have feedback on the suggestions you didn't take?

@shraddhabang @johngmyers
Apply suggestions from code review
3cb255f 
Co-authored-by: John Gardiner Myers <[email protected]>
@shraddhabang
Copy link
Collaborator Author

@johngmyers Apologies for missing some changes. Thank you for all the suggestions. I have now included all in the recent commit. Please take a look.

@oliviassss oliviassss mentioned this pull request Aug 14, 2023
Closed
M00nF1sh
M00nF1sh approved these changes Aug 14, 2023
View reviewed changes
Copy link
Collaborator

@M00nF1sh M00nF1sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 14, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: M00nF1sh, shraddhabang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit 95f7b06 into kubernetes-sigs:main Aug 14, 2023
@johngmyers johngmyers mentioned this pull request Aug 23, 2023
Merged
12 tasks
@shraddhabang shraddhabang mentioned this pull request Jan 17, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviassss oliviassss oliviassss left review comments

@johngmyers johngmyers johngmyers left review comments

@M00nF1sh M00nF1sh M00nF1sh approved these changes

Assignees

@M00nF1sh M00nF1sh

@oliviassss oliviassss

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shraddhabang @k8s-ci-robot @oliviassss @johngmyers @M00nF1sh