Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow TLS 1.2 with restricted ciphers for webhooks #3318

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Allow TLS 1.2 with restricted ciphers for webhooks #3318

merged 1 commit into from
Aug 9, 2023

Conversation

johngmyers
Copy link
Contributor

Issue

Not filed

Description

Allows TLS 1.2 to be used for the webhook server, for environments which do not support TLS 1.3 (for example, those requiring FIPS 140). Restricts the allowable TLS 1.2 ciphers to address the concerns in #2531

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 8, 2023
@johngmyers johngmyers mentioned this pull request Aug 8, 2023
Closed
4 tasks
@alebedev87 alebedev87 mentioned this pull request Aug 9, 2023
Merged
@oliviassss
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2023
M00nF1sh
M00nF1sh approved these changes Aug 9, 2023
View reviewed changes
Copy link
Collaborator

@M00nF1sh M00nF1sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers, M00nF1sh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2023
@oliviassss oliviassss merged commit ca1086f into kubernetes-sigs:main Aug 9, 2023
2 checks passed
@johngmyers johngmyers deleted the tls-vers branch August 10, 2023 00:12
@johngmyers johngmyers mentioned this pull request Aug 23, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M00nF1sh M00nF1sh M00nF1sh approved these changes

@oliviassss oliviassss Awaiting requested review from oliviassss

Assignees

@M00nF1sh M00nF1sh

@oliviassss oliviassss

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@johngmyers @oliviassss @k8s-ci-robot @M00nF1sh