config_types: Add weight validation #3312

jkdihenkar · 2023-08-07T06:52:36Z

Adding a model validation for weights as described in the AWS LB Documentation -

https://docs.aws.amazon.com/elasticloadbalancing/latest/application/load-balancer-listeners.html#:~:text=You%20can%20use%20forward%20actions%20to%20route%20requests%20to%20one%20or%20more%20target%20groups.%20If%20you%20specify%20multiple%20target%20groups%20for%20a%20forward%20action%2C%20you%20must%20specify%20a%20weight%20for%20each%20target%20group.%20Each%20target%20group%20weight%20is%20a%20value%20from%200%20to%20999.

Issue

Description

Checklist

Added tests that cover your change (if possible)
Added/modified documentation as required (such as the README.md, or the docs directory)
Manually tested
Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

Backfilled missing tests for code in same general area 🎉
Refactored something and made the world a better place 🌟

k8s-ci-robot · 2023-08-07T06:52:44Z

Welcome @jkdihenkar!

It looks like this is your first PR to kubernetes-sigs/aws-load-balancer-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-load-balancer-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2023-08-07T06:52:45Z

Hi @jkdihenkar. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jkdihenkar · 2023-08-07T18:47:59Z

/ok-to-test

k8s-ci-robot · 2023-08-07T18:48:12Z

@jkdihenkar: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jkdihenkar · 2023-08-07T18:49:14Z

@kishorj @M00nF1sh - can you check this once?

johngmyers · 2023-08-09T00:28:33Z

/ok-to-test

jkdihenkar · 2023-08-09T19:16:04Z

@johngmyers - tests have passed. can you please review and help this move ahead?

johngmyers · 2023-08-10T00:15:51Z

pkg/ingress/config_types.go

@@ -88,6 +88,10 @@ func (t *TargetGroupTuple) validate() error {
 	if t.ServiceName != nil && t.ServicePort == nil {
 		return errors.New("missing servicePort")
 	}
+
+	if (t.Weight != nil) && (*(t.Weight) < 0 || *(t.Weight) > 999) {


Counsider using aws.Int64Value()

review accepted, changes done. thanks for this 🙌

johngmyers · 2023-08-10T00:16:29Z

pkg/ingress/config_types.go

@@ -88,6 +88,10 @@ func (t *TargetGroupTuple) validate() error {
 	if t.ServiceName != nil && t.ServicePort == nil {
 		return errors.New("missing servicePort")
 	}
+
+	if (t.Weight != nil) && (*(t.Weight) < 0 || *(t.Weight) > 999) {
+		return errors.New("The weight for each target group must be between 0 and 999, inclusive")


Error messages should not start with a capital letter. It should probably be worded something like "weight is not between 0 and 999, inclusive"

review accepted, changes done

kishorj · 2023-08-10T13:57:06Z

/retest

johngmyers · 2023-08-11T04:13:55Z

/lgtm

johngmyers · 2023-08-11T04:14:17Z

/retest

johngmyers · 2023-08-11T04:17:39Z

@jkdihenkar it might be necessary to rebase in order to get the e2e test to pass.

johngmyers · 2023-08-11T04:19:00Z

pkg/ingress/config_types.go

@@ -88,6 +89,10 @@ func (t *TargetGroupTuple) validate() error {
 	if t.ServiceName != nil && t.ServicePort == nil {
 		return errors.New("missing servicePort")
 	}
+
+	if aws.Int64Value(t.Weight) < 0 || aws.Int64Value(t.Weight) > 999 {


Ah, we no longer pull in aws-sdk-go-v2. You need to refer to the Int64Value that is in aws-sdk-go

review accepted!

johngmyers · 2023-08-11T04:19:13Z

/lgtm cancel

jkdihenkar · 2023-08-24T12:51:17Z

/retest

jkdihenkar · 2023-08-25T05:27:22Z

@johngmyers - can you please take a look now?

johngmyers · 2023-08-29T23:41:28Z

/lgtm

jkdihenkar · 2023-09-03T08:04:53Z

How do we get this merged into master?

k8s-triage-robot · 2024-01-21T09:18:51Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

oliviassss · 2024-01-24T19:54:11Z

Thanks for the contribution and sorry for the delay.

/lgtm
/approve

k8s-ci-robot · 2024-01-24T19:54:18Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkdihenkar, oliviassss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [oliviassss]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

oliviassss · 2024-01-25T21:48:39Z

@jkdihenkar, can you please rebase the main branch to pick up the fix to e2e tests failure? I cannot merge without test passing. Thanks
#3539

k8s-triage-robot · 2024-02-24T22:32:25Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-ci-robot · 2024-03-01T11:04:17Z

New changes are detected. LGTM label has been removed.

Adding a model validation for weights as described in the AWS LB Documentation - https://docs.aws.amazon.com/elasticloadbalancing/latest/application/load-balancer-listeners.html#:~:text=You%20can%20use%20forward%20actions%20to%20route%20requests%20to%20one%20or%20more%20target%20groups.%20If%20you%20specify%20multiple%20target%20groups%20for%20a%20forward%20action%2C%20you%20must%20specify%20a%20weight%20for%20each%20target%20group.%20Each%20target%20group%20weight%20is%20a%20value%20from%200%20to%20999.

jkdihenkar · 2024-03-13T05:23:20Z

@oliviassss - can you take a look now?

k8s-triage-robot · 2024-04-12T05:58:10Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen
Mark this PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2024-04-12T05:58:15Z

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen

Mark this PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot requested review from kishorj and M00nF1sh August 7, 2023 06:52

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 7, 2023

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 7, 2023

k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 7, 2023

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 9, 2023

johngmyers reviewed Aug 10, 2023

View reviewed changes

kishorj added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 10, 2023

k8s-ci-robot assigned johngmyers Aug 11, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 11, 2023

johngmyers reviewed Aug 11, 2023

View reviewed changes

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 11, 2023

johngmyers mentioned this pull request Aug 23, 2023

Add johngmyers as approver #3356

Merged

12 tasks

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2023

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 21, 2024

k8s-ci-robot assigned oliviassss Jan 24, 2024

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2024

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 24, 2024

jkdihenkar force-pushed the config_types-weight-validation branch from 8f22d99 to 467754d Compare March 1, 2024 11:04

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2024

k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 1, 2024

jkdihenkar and others added 4 commits March 1, 2024 16:39

fixup: config_types-weight-validation, weight being pointer

4b30155

review changes: reword error msg and use aws.Int64Value

c9ca86c

fixup: move to aws-sdk-go instead of v2

1a808a2

jkdihenkar force-pushed the config_types-weight-validation branch from 467754d to 1a808a2 Compare March 1, 2024 11:09

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 1, 2024

k8s-ci-robot closed this Apr 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

config_types: Add weight validation #3312

config_types: Add weight validation #3312

jkdihenkar commented Aug 7, 2023

k8s-ci-robot commented Aug 7, 2023

k8s-ci-robot commented Aug 7, 2023

jkdihenkar commented Aug 7, 2023

k8s-ci-robot commented Aug 7, 2023

jkdihenkar commented Aug 7, 2023

johngmyers commented Aug 9, 2023

jkdihenkar commented Aug 9, 2023

johngmyers Aug 10, 2023

jkdihenkar Aug 10, 2023

johngmyers Aug 10, 2023 •

edited

Loading

jkdihenkar Aug 10, 2023 •

edited

Loading

kishorj commented Aug 10, 2023

johngmyers commented Aug 11, 2023

johngmyers commented Aug 11, 2023

johngmyers commented Aug 11, 2023

johngmyers Aug 11, 2023

jkdihenkar Aug 24, 2023

johngmyers commented Aug 11, 2023

jkdihenkar commented Aug 24, 2023

jkdihenkar commented Aug 25, 2023

johngmyers commented Aug 29, 2023

jkdihenkar commented Sep 3, 2023

k8s-triage-robot commented Jan 21, 2024

oliviassss commented Jan 24, 2024

k8s-ci-robot commented Jan 24, 2024

oliviassss commented Jan 25, 2024

k8s-triage-robot commented Feb 24, 2024

k8s-ci-robot commented Mar 1, 2024

jkdihenkar commented Mar 13, 2024

k8s-triage-robot commented Apr 12, 2024

k8s-ci-robot commented Apr 12, 2024

config_types: Add weight validation #3312

config_types: Add weight validation #3312

Conversation

jkdihenkar commented Aug 7, 2023

Issue

Description

Checklist

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

k8s-ci-robot commented Aug 7, 2023

k8s-ci-robot commented Aug 7, 2023

jkdihenkar commented Aug 7, 2023

k8s-ci-robot commented Aug 7, 2023

jkdihenkar commented Aug 7, 2023

johngmyers commented Aug 9, 2023

jkdihenkar commented Aug 9, 2023

johngmyers Aug 10, 2023

Choose a reason for hiding this comment

jkdihenkar Aug 10, 2023

Choose a reason for hiding this comment

johngmyers Aug 10, 2023 • edited Loading

Choose a reason for hiding this comment

jkdihenkar Aug 10, 2023 • edited Loading

Choose a reason for hiding this comment

kishorj commented Aug 10, 2023

johngmyers commented Aug 11, 2023

johngmyers commented Aug 11, 2023

johngmyers commented Aug 11, 2023

johngmyers Aug 11, 2023

Choose a reason for hiding this comment

jkdihenkar Aug 24, 2023

Choose a reason for hiding this comment

johngmyers commented Aug 11, 2023

jkdihenkar commented Aug 24, 2023

jkdihenkar commented Aug 25, 2023

johngmyers commented Aug 29, 2023

jkdihenkar commented Sep 3, 2023

k8s-triage-robot commented Jan 21, 2024

oliviassss commented Jan 24, 2024

k8s-ci-robot commented Jan 24, 2024

oliviassss commented Jan 25, 2024

k8s-triage-robot commented Feb 24, 2024

k8s-ci-robot commented Mar 1, 2024

jkdihenkar commented Mar 13, 2024

k8s-triage-robot commented Apr 12, 2024

k8s-ci-robot commented Apr 12, 2024

johngmyers Aug 10, 2023 •

edited

Loading

jkdihenkar Aug 10, 2023 •

edited

Loading