Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add oliviassss as reviewer #3306

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Conversation

oliviassss
Copy link
Collaborator

Issue

Description

add oliviassss as reviewer and approver

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 3, 2023
Copy link
Collaborator

@M00nF1sh M00nF1sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 3, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: M00nF1sh, oliviassss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2023
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (d1b8fbb) 54.76% compared to head (be725f6) 54.76%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3306   +/-   ##
=======================================
  Coverage   54.76%   54.76%           
=======================================
  Files         148      148           
  Lines        8601     8601           
=======================================
  Hits         4710     4710           
  Misses       3559     3559           
  Partials      332      332           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johngmyers
Copy link
Contributor

A requirement for approver is to have been a reviewer for at least three months.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2023
@johngmyers
Copy link
Contributor

Requirements for reviewer and approver are at https://github.com/kubernetes/community/blob/master/community-membership.md

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 3, 2023
@oliviassss
Copy link
Collaborator Author

@johngmyers changed to reviewer only.

@oliviassss oliviassss changed the title add oliviassss as reviewer and approver add oliviassss as reviewer Aug 3, 2023
@kishorj kishorj added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 4, 2023
@kishorj
Copy link
Collaborator

kishorj commented Aug 4, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2023
@johngmyers
Copy link
Contributor

@oliviassss Thank you. Could you enumerate the 5 PRs where you've been the primary reviewer and the 20 substantial PRs you've either reviewed or merged?

@oliviassss oliviassss merged commit 9e8f685 into kubernetes-sigs:main Aug 4, 2023
2 checks passed
@oliviassss oliviassss deleted the update-file branch August 4, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants