-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add oliviassss as reviewer #3306
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: M00nF1sh, oliviassss The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #3306 +/- ##
=======================================
Coverage 54.76% 54.76%
=======================================
Files 148 148
Lines 8601 8601
=======================================
Hits 4710 4710
Misses 3559 3559
Partials 332 332 ☔ View full report in Codecov by Sentry. |
A requirement for approver is to have been a reviewer for at least three months. |
Requirements for reviewer and approver are at https://github.com/kubernetes/community/blob/master/community-membership.md |
@johngmyers changed to reviewer only. |
/lgtm |
@oliviassss Thank you. Could you enumerate the 5 PRs where you've been the primary reviewer and the 20 substantial PRs you've either reviewed or merged? |
Issue
Description
add oliviassss as reviewer and approver
Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯