fix the race condition in pod cache and endpoint resolver #3305
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#3299
Description
The pod informer and endpoints informer works independently. In some edge case, the pod is created and exists in endpoints, but when we find the podIP in endpoints, the pod is not propagated in our informer cache yet. But in the code above we simply ignored it and never retries. (and since this pod has a readinessGate, it never became ready in endpoints so no further reconcile is triggered).
For now, We can fixe this by setting containsPotentialReadyEndpoints=true if the pod in endpoints is not found in pod cache yet (so there will be a retry later).
In the future, we'll add a pod event watcher to address this issue nicely, i.e. this TODO
Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯