Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate away from deprecated kustomize features #3091

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Migrate away from deprecated kustomize features #3091

wants to merge 9 commits into from

Commits on Oct 1, 2024

  1. Clean up kustomizations 

      - Always include apiVersion+kind of kustomization files
  - `patchesStrategicMerge` was deprecated, use `patches` instead
  - `bases` was deprecated, use `resources` instead
  - Order `configurations` first
    @james-callahan
    james-callahan committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    17f2146 View commit details
    Browse the repository at this point in the history

  2. Use commonLabels

    @james-callahan
    james-callahan committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    0d1967e View commit details
    Browse the repository at this point in the history

  3. Add ports declaration to controller container

    @james-callahan
    james-callahan committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    94bf1df View commit details
    Browse the repository at this point in the history

  4. Consolidate cert-manager kustomize pieces into the one component

    @james-callahan
    james-callahan committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    5eee576 View commit details
    Browse the repository at this point in the history

  5. Consolidate webhook kustomize pieces into the one component

    @james-callahan
    james-callahan committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    b52681b View commit details
    Browse the repository at this point in the history

  6. Kustomize deprecated vars, use replacements

    @james-callahan
    james-callahan committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    2b43076 View commit details
    Browse the repository at this point in the history

  7. Use CRD v1 form 

    kustomize also requires that we specify a namespace here, or else it won't add one
    @james-callahan
    james-callahan committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    fdfe40a View commit details
    Browse the repository at this point in the history

  8. caBundle doesn't need to be set 

    And it causes the resource to show up in e.g. ArgoCD as Out-of-Sync
    @james-callahan
    james-callahan committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    e81534c View commit details
    Browse the repository at this point in the history

  9. Remove hardcoded namespaces 

    kustomize will fill these in for us
    @james-callahan
    james-callahan committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    506fd88 View commit details
    Browse the repository at this point in the history