fix: Add revisionHistoryLimit override (#3486)

Signed-off-by: Matt Dainty <[email protected]>
kubernetes-sigs · Jan 30, 2024 · 41ebb0b · 41ebb0b
1 parent d0c13bf
commit 41ebb0b
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 0 deletions.
diff --git a/helm/aws-load-balancer-controller/README.md b/helm/aws-load-balancer-controller/README.md
@@ -246,6 +246,7 @@ The default values set by the application itself can be confirmed [here](https:/
 | `extraVolumes`                                 | Extra volumes for the pod                                                                                                                                                                                              | `[]`                                              |
 | `defaultTags`                                  | Default tags to apply to all AWS resources managed by this controller                                                                                                                                                  | `{}`                                              |
 | `replicaCount`                                 | Number of controller pods to run, only one will be active due to leader election                                                                                                                                       | `2`                                               |
+| `revisionHistoryLimit`                         | Number of revisions to keep                                                                                                                                                                                            | `10`                                              |
 | `podDisruptionBudget`                          | Limit the disruption for controller pods. Require at least 2 controller replicas and 3 worker nodes                                                                                                                    | `{}`                                              |
 | `updateStrategy`                               | Defines the update strategy for the deployment                                                                                                                                                                         | `{}`                                              |
 | `enableCertManager`                            | If enabled, cert-manager issues the webhook certificates instead of the helm template, requires cert-manager and it's CRDs to be installed                                                                             | `false`                                           |

diff --git a/helm/aws-load-balancer-controller/templates/deployment.yaml b/helm/aws-load-balancer-controller/templates/deployment.yaml
@@ -11,6 +11,7 @@ metadata:
     {{- include "aws-load-balancer-controller.labels" . | nindent 4 }}
 spec:
   replicas: {{ .Values.replicaCount }}
+  revisionHistoryLimit: {{ .Values.revisionHistoryLimit }}
   selector:
     matchLabels:
       {{- include "aws-load-balancer-controller.selectorLabels" . | nindent 6 }}

diff --git a/helm/aws-load-balancer-controller/values.yaml b/helm/aws-load-balancer-controller/values.yaml
@@ -4,6 +4,8 @@
 
 replicaCount: 2
 
+revisionHistoryLimit: 10
+
 image:
   repository: public.ecr.aws/eks/aws-load-balancer-controller
   tag: v2.6.1