-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow to don't use helm hooks for CSIDriver creation #1074
base: master
Are you sure you want to change the base?
Conversation
Welcome @woehrl01! |
Hi @woehrl01. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: woehrl01 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We're affected by this issue as well, thank you @woehrl01 for making a PR. @justinsb @mskanth972 is there any chance that one of you can review this soon !? |
/ok-to-test |
Hi @mskanth972 @jqmichael |
ping |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
/remove-lifecycle rotten |
Is this a bug fix or adding new feature?
Fixes #765
Fixes #325
What is this PR about? / Why do we need it?
According to how external tools are executing the hooks, there can be a possibility that the CSIDriver gets deleted but never created. This PR adds a flag, so that the CSIDriver can be added without using helm hooks. This has the benefit that the Csidriver doesn't gets constantly recreated on each update of the chart (which doesn't make scene, imho)
Adds a flag
useHelmHooksForCSIDriver
to Values, which can be used to disable usage of hooks.Currently, does not change the default behaviour to not impact existing users.
What testing is done?
Verified that the sources does not show up as deleted