Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disk/ListSnapshots: refactor to comply with CSI #1016

Merged
merged 1 commit into from
May 27, 2024

Conversation

huww98
Copy link
Contributor

@huww98 huww98 commented Apr 7, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

disk/ListSnapshots: refactor to comply with CSI

workaround that ECS don't support max_entries < 10

Which issue(s) this PR fixes:

Fixes all CSI-sanity cases of ListSnapshots:

  • listsnapshots [controller server] [it] should return appropriate values (no optional values added)
  • listsnapshots [controller server] [it] should return empty when the specified snapshot id does not exist
  • listsnapshots [controller server] [it] should return snapshots that match the specified source volume id
  • listsnapshots [controller server] [it] should return empty when the specified source volume id does not exist
  • listsnapshots [controller server] [it] check the presence of new snapshots in the snapshot list
  • listsnapshots [controller server] [it] should return next token when a limited number of entries are requested

Special notes for your reviewer:

This routine is not important to Kubernetes. But as a CSI driver, we'd better correctly implement it.

Does this PR introduce a user-facing change?

ListSnapshots for disk plugin is re-implemented to comply with CSI. (no changes for Kubernetes users)

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 7, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @huww98. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 7, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 26, 2024
workaround that ECS don't support max_entries < 10
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 27, 2024
@huww98
Copy link
Contributor Author

huww98 commented Apr 27, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 27, 2024
@huww98

This comment was marked as resolved.

@mowangdk
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 27, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huww98, mowangdk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2024
@k8s-ci-robot k8s-ci-robot merged commit c378ba4 into kubernetes-sigs:master May 27, 2024
6 of 7 checks passed
@huww98 huww98 deleted the disk-list-snapshot branch May 28, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants