Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating ClusterProperty API to v1betav1 #27

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

holgerson97
Copy link
Contributor

@holgerson97 holgerson97 commented Oct 21, 2024

closes: #18

I upgrade the API files and adapted Makefile to support multiple CRD versions.
Is there more required to do to close issue #18?

NOTE Since I updated controller-gen in a different PR this one should probably merged afterwards and manifest freshly generated with new version.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: holgerson97
Once this PR has been reviewed and has the lgtm label, please assign jeremyot for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 21, 2024
@ryanzhang-oss
Copy link

I am not sure if the About API is ready to move to v1beta1 yet. There are a bunch of properties that we would like to add.

@lauralorenz
Copy link
Contributor

Thank you @holgerson97!!!! This is awesome!! I will catch up on these after Kubecon.

@ryanzhang-oss About API graduated to beta last year actually, but the repo hasn't caught up. Adding properties (if by that you mean, more records) is always possible; and well known properties can also be defined if that's what you mean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CRD to beta maturity
4 participants