Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped GinkGo@v2 and [email protected] #26

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

holgerson97
Copy link
Contributor

@holgerson97 holgerson97 commented Oct 13, 2024

Description

I want to bump the GinkGo Version.
ref: #16

The latest version is:

gh release list -R onsi/ginkgo --json isLatest --json tagName
[
  {
    "isLatest": true,
    "tagName": "v2.20.2"
  },
...

As of this PR into the controller runtime package we also need to update the package itself to be compatible with GinkGo@V2.
PR: Controller Runtime PR

I don't wanted to skip to latest version of Controller Runtime since there might be more migration needed which would be out of scope for this PR. The release containing the breaking changes is as follows:

❯ gh release view "v0.14.0" -R kubernetes-sigs/controller-runtime
vincepri released this about 1 year ago

  ## Changes since v0.13.1

  ## ⚠️  Breaking Changes

  • Add Get functionality to SubResourceClient (#2094)
  • Allow configuring RecoverPanic for controllers globally (#2093)
  • Add client.SubResourceWriter (#2072)
  • Support registration and removal of event handler (#2046)
  • Update Kubernetes dependencies to v0.26 (#2043, #2087)
  • Zap log: Default to RFC3339 time encoding (#2029)
  • cache.BuilderWithOptions inherit options from caller (#1980)
  • Migrate to ginkgo v2 (https://github.com/kubernetes-sigs/controller-runtime/pull/1977),
  this removes the  pkg/envtest/printer  package
...

The latest patch version of v0.14.X is v0.14.7

❯ gh release list -R kubernetes-sigs/controller-runtime --json isLatest --json tagName -L 1

[
  {
    "isLatest": true,
    "tagName": "v0.19.0"
  }
]

NOTE: I also needed to bump Go to 1.22 to be compatible with GinkGo@v2

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: holgerson97
Once this PR has been reviewed and has the lgtm label, please assign pmorie for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 13, 2024
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants