Bumped to [email protected] and build dependencies

[holgerson97]

I have some additional questions, resulting in maybe additional PRs:

• Should Kustomize be bumped V5?
• Currently when building the Docker image we inherit Make target test. This makes it impossible to build the Docker image and actually test it.

.PHONY: docker-build
docker-build: test ## Build docker image with the manager.
	docker build -t ${IMG} .

• Should we add a description on how to setup a local test environment with k3d/Kind?
• Test will always fail because of CRD approval, should we adapt those test cases?

msg: "unable to create CRD \"clusterproperties.about.k8s.io\": CustomResourceDefinition.apiextensions.k8s.io \"clusterproperties.about.k8s.io\" is invalid: metadata.annotations[api-approved.kubernetes.io]: Required value: protected groups must have approval annotation \"api-approved.kubernetes.io\", see https://github.com/kubernetes/enhancements/pull/1111"

• The tests use an outdated version from Ginkgo, should we migrate here also to a newer version?

closes: #21

[k8s-ci-robot]

Welcome @holgerson97!

It looks like this is your first PR to kubernetes-sigs/about-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/about-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[lauralorenz]

Should Kustomize be bumped V5?

yes though this may also interact with #16

Currently when building the Docker image we inherit Make target test. This makes it impossible to build the Docker image and actually test it.

hm that's not useful is it 😅 . This also might overlap with #16. But regardless, even though the makefile originates from kubebuilder, we can edit it to suit if needed.

Should we add a description on how to setup a local test environment with k3d/Kind?

Sure! That would be useful both here and maybe at https://github.com/kubernetes-sigs/sig-multicluster-site too.

Test will always fail because of CRD approval, should we adapt those test cases?

Drat I thought this was fixed in #11. Possibly we just need another make manifests run or need to edit that to make sure it uses kustomize properly.

The tests use an outdated version from Ginkgo, should we migrate here also to a newer version?

Sure! Also check to see if that overlaps with #16.

I do agree these should be separate PRs, but for most of them, if you're interested in working on them can you check to see if addressing #16 addresses them or not? Then maybe we can do a bunch at once with a kubebuilder update.

[lauralorenz]

Test will always fail because of CRD approval, should we adapt those test cases?
Looking back I think #20 was actually addressing this, but it got stuck at some point.

/lgtm

I do think this is ok for now but we do have a cleanup issue where I think not all of #10 (comment) was implemented and so we have this hanging go.mod (edited in this PR) when the "real" one should be the root go.mod. I'll spin off something separate about handling that.

/approve

thanks for taking a stab at it!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: holgerson97, lauralorenz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lauralorenz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[holgerson97]

Should Kustomize be bumped V5?

yes though this may also interact with #16

Currently when building the Docker image we inherit Make target test. This makes it impossible to build the Docker image and actually test it.

hm that's not useful is it 😅 . This also might overlap with #16. But regardless, even though the makefile originates from kubebuilder, we can edit it to suit if needed.

Should we add a description on how to setup a local test environment with k3d/Kind?

Sure! That would be useful both here and maybe at https://github.com/kubernetes-sigs/sig-multicluster-site too.

Test will always fail because of CRD approval, should we adapt those test cases?

Drat I thought this was fixed in #11. Possibly we just need another make manifests run or need to edit that to make sure it uses kustomize properly.

The tests use an outdated version from Ginkgo, should we migrate here also to a newer version?

Sure! Also check to see if that overlaps with #16.

I do agree these should be separate PRs, but for most of them, if you're interested in working on them can you check to see if addressing #16 addresses them or not? Then maybe we can do a bunch at once with a kubebuilder update.

I will go over everything this week and create another PR. Thanks for the clarification.