Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped to [email protected] and build dependencies #24

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

holgerson97
Copy link

@holgerson97 holgerson97 commented Sep 8, 2024

I have some additional questions, resulting in maybe additional PRs:

  • Should Kustomize be bumped V5?
  • Currently when building the Docker image we inherit Make target test. This makes it impossible to build the Docker image and actually test it.
.PHONY: docker-build
docker-build: test ## Build docker image with the manager.
	docker build -t ${IMG} .
  • Should we add a description on how to setup a local test environment with k3d/Kind?
  • Test will always fail because of CRD approval, should we adapt those test cases?
msg: "unable to create CRD \"clusterproperties.about.k8s.io\": CustomResourceDefinition.apiextensions.k8s.io \"clusterproperties.about.k8s.io\" is invalid: metadata.annotations[api-approved.kubernetes.io]: Required value: protected groups must have approval annotation \"api-approved.kubernetes.io\", see https://github.com/kubernetes/enhancements/pull/1111"
  • The tests use an outdated version from Ginkgo, should we migrate here also to a newer version?

closes: #21

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: holgerson97
Once this PR has been reviewed and has the lgtm label, please assign lauralorenz for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 8, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @holgerson97!

It looks like this is your first PR to kubernetes-sigs/about-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/about-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No such file or directory
2 participants