Add support for OSB parameter schemas #822
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
@pmorie changes look ok, but I'd like to see what the controller does with these, so I have a bigger picture. Ping me when you want another review |
|
@arschles the controller will do nothing except transform them from the appropriate buckets in the OSB API. These are basically there for people to build UIs around at this point; we can just treat them like blobs. |
|
Still needs:
|
pmorie
changed the title
pmorie
changed the title
|
As per discussions in the Open Service Broker F2F the proposal being investigated is that the schemas are going to be on the ServiceInstance/ServiceBinding, and not below that in separate methods (like Create / Update, etc.) So, let's hold off on this a little bit. |
|
@vaikas-google
This implements what is in the proposal here: openservicebrokerapi/servicebroker#165 - did something change during the week? |
|
I have a business need to get something in to carry schema information ASAP, so unless the proposal has been redrafted, I would like for this to be in the next release. |
|
It looks based on this comment like Matt thinks the proposal should stay the way it is: openservicebrokerapi/servicebroker#165 (comment) |
pmorie
changed the title
| Instance Schema `json:"instance"` | ||
| Binding Schema `json:"binding"` | ||
| ServiceInstances *Schema `json:"service_instances,omitempty"` | ||
| ServiceBindings *Schema `json:"service_bindings,omitempty"` |
There was a problem hiding this comment.
this changes the wire protocol for communicating with brokers, no?
There was a problem hiding this comment.
It changes the application-layer messages, but they were not correct in terms of the actual proposed change to begin with. They are correct after this PR.
|
No tests? |
|
My bad - this has been pending for long enough I had forgotten that I had a couple tests to add. |
Closes #490.
I'm posting this early to see how people feel about the changes to our API; I'll finish the rest when I have cause to believe I won't have to re-do the API changes.
Believe it or not I have gone through a couple iterations before posting this that I didn't like.