Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit test for util #4060

Merged
merged 14 commits into from
May 31, 2024
Merged

add unit test for util #4060

merged 14 commits into from
May 31, 2024

Conversation

zcq98
Copy link
Member

@zcq98 zcq98 commented May 21, 2024

Pull Request

What type of this PR

Examples of user facing changes:

  • Tests

Which issue(s) this PR fixes

@zcq98 zcq98 marked this pull request as ready for review May 28, 2024 12:00
@zcq98
Copy link
Member Author

zcq98 commented May 29, 2024

@bobz965 Could you help review this?

pkg/util/net_test.go Outdated Show resolved Hide resolved
pkg/util/strings_test.go Outdated Show resolved Hide resolved
pkg/util/subnet_test.go Outdated Show resolved Hide resolved
pkg/util/net_test.go Outdated Show resolved Hide resolved
pkg/util/net_test.go Outdated Show resolved Hide resolved
pkg/util/ovn_test.go Outdated Show resolved Hide resolved
pkg/util/strings_test.go Outdated Show resolved Hide resolved
pkg/util/validator_test.go Outdated Show resolved Hide resolved
pkg/util/vpc_nat_gateway_test.go Outdated Show resolved Hide resolved
pkg/util/vpc_nat_gateway_test.go Outdated Show resolved Hide resolved
@zcq98 zcq98 force-pushed the util-ut branch 2 times, most recently from ace30be to 6369ec2 Compare May 29, 2024 05:59
@bobz965
Copy link
Collaborator

bobz965 commented May 30, 2024

@zhangzujian could you please help review? thanks!

zcq98 and others added 14 commits May 31, 2024 14:11
Co-authored-by: bobz965 <[email protected]>
Signed-off-by: zcq98 <[email protected]>
Co-authored-by: bobz965 <[email protected]>
Signed-off-by: zcq98 <[email protected]>
Co-authored-by: bobz965 <[email protected]>
Signed-off-by: zcq98 <[email protected]>
Co-authored-by: bobz965 <[email protected]>
Signed-off-by: zcq98 <[email protected]>
Co-authored-by: bobz965 <[email protected]>
Signed-off-by: zcq98 <[email protected]>
Co-authored-by: bobz965 <[email protected]>
Signed-off-by: zcq98 <[email protected]>
Co-authored-by: bobz965 <[email protected]>
Signed-off-by: zcq98 <[email protected]>
Co-authored-by: bobz965 <[email protected]>
Signed-off-by: zcq98 <[email protected]>
Co-authored-by: bobz965 <[email protected]>
Signed-off-by: zcq98 <[email protected]>
Co-authored-by: bobz965 <[email protected]>
Signed-off-by: zcq98 <[email protected]>
Co-authored-by: bobz965 <[email protected]>
Signed-off-by: zcq98 <[email protected]>
@bobz965 bobz965 merged commit d5f90bf into kubeovn:master May 31, 2024
10 of 12 checks passed
@zcq98 zcq98 deleted the util-ut branch May 31, 2024 06:21
bobz965 added a commit that referenced this pull request Jun 3, 2024
* add unit test for util

---------

Signed-off-by: zcq98 <[email protected]>
Co-authored-by: bobz965 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test automation tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants