-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PSS restricted warnings #11751
base: master
Are you sure you want to change the base?
Fix PSS restricted warnings #11751
Conversation
Hi @akagami-harsh. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Harshvir Potpose <[email protected]>
c4f6a4f
to
10bbd8b
Compare
seccompProfile: | ||
type: RuntimeDefault |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you adding it to spec.template.spec.containers
here while in the other files, you moved from spec.template.spec.containers
to spec.template.spec
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is indeed under spec.template.spec
, it is not inside containers
; it is just placed below containers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'll add it above to avoid confusion.
/ok-to-test |
Signed-off-by: Harshvir Potpose <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/unhold
Yes, I also think that it is good enough for merging. We just need an approval @HumairAK |
This PR has good no of best practices. Will this be included in 1.10 release? |
If the maintainers of KFP here approve it I can apply it as hotfix. But maybe is slips into 1.10.1. |
Description of your changes:
related to kubeflow/manifests#3050
Checklist: