Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PSS restricted warnings #11751

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

akagami-harsh
Copy link
Contributor

Description of your changes:
related to kubeflow/manifests#3050

Checklist:

Copy link

Hi @akagami-harsh. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zijianjoy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot requested review from gkcalat and zijianjoy March 16, 2025 09:04
Signed-off-by: Harshvir Potpose <[email protected]>
@juliusvonkohout
Copy link
Member

/lgtm
/hold

for @hbelmiro and @HumairAK

Comment on lines 52 to 53
seccompProfile:
type: RuntimeDefault
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you adding it to spec.template.spec.containers here while in the other files, you moved from spec.template.spec.containers to spec.template.spec?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is indeed under spec.template.spec, it is not inside containers; it is just placed below containers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'll add it above to avoid confusion.

@hbelmiro
Copy link
Contributor

/ok-to-test

Signed-off-by: Harshvir Potpose <[email protected]>
@google-oss-prow google-oss-prow bot removed the lgtm label Mar 17, 2025
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/unhold

@juliusvonkohout
Copy link
Member

/lgtm /unhold

Yes, I also think that it is good enough for merging. We just need an approval @HumairAK

@nithin8702
Copy link

This PR has good no of best practices. Will this be included in 1.10 release?

@juliusvonkohout
Copy link
Member

This PR has good no of best practices. Will this be included in 1.10 release?

If the maintainers of KFP here approve it I can apply it as hotfix. But maybe is slips into 1.10.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants