feat(ws): Implement workspace start + pause as backend APIs #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
andyatmiami
force-pushed
the
feat/workspace-start-api
branch
3 times, most recently
from
fb2e2fb to
f22b3d3
Compare
andyatmiami
force-pushed
the
feat/workspace-start-api
branch
2 times, most recently
from
8d5e467 to
3237336
Compare
andyatmiami
changed the title
andyatmiami
force-pushed
the
feat/workspace-start-api
branch
from
3237336 to
ba9e1bc
Compare
related: kubeflow#298 - Added StartWorkspaceHandler + PauseWorkspaceHandler to handle the respective workspace actions - Introduced new routes for starting and pausing workspaces in the API. - `api/v1/workspaces/{namespace}/{name}/actions/start` - `api/v1/workspaces/{namespace}/{name}/actions/pause` - Created a new PauseStateEnvelope type for successful responses. - Leveraging JSONPatch / client.RawPatch to ensure Workspace in "valid state" before attempting action - for `start`: `spec.paused` must be `true`, and `status.state` must be `Paused` - for `pause`: `spec.paused` must be `false` - note: I would love to have a `status.state` check here of `status.state != Paused`, but that type of comparison is not supported in [JSONPatch](https://datatracker.ietf.org/doc/html/rfc6902#section-4.6) - Added tests for the new APIs, including success and error cases. - Updated README/OpenAPI documentation to include the new endpoints. Signed-off-by: Andy Stoneberg <[email protected]>
andyatmiami
force-pushed
the
feat/workspace-start-api
branch
from
ba9e1bc to
575e1a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #298
api/v1/workspaces/{namespace}/{name}/actions/startapi/v1/workspaces/{namespace}/{name}/actions/pausestart:spec.pausedmust betrue, andstatus.statemust bePausedpause:spec.pausedmust befalsestatus.statecheck here ofstatus.state != Paused, but that type of comparison is not supported in JSONPatchFunctionality tested/verified via generated Swagger client:
HAPPY PATH
ERROR PATH
